[
https://issues.apache.org/jira/browse/CLIMATE-654?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14652034#comment-14652034
]
ASF GitHub Bot commented on CLIMATE-654:
----------------------------------------
Github user huikyole commented on the pull request:
https://github.com/apache/climate/pull/219#issuecomment-127288137
@MJJoyce, this separation does not make a lot of sense. Checking units and
converting them are not computationally demanding. Why don't we have a single
function applicable to both temperature and precipitation variables? Having
temperature_unit_conversion and water_flux_unit_conversion separately means we
need the 'IF' statements whenever we call these functions.
> Clean up duplicate unit conversion code
> ---------------------------------------
>
> Key: CLIMATE-654
> URL: https://issues.apache.org/jira/browse/CLIMATE-654
> Project: Apache Open Climate Workbench
> Issue Type: Improvement
> Components: regridding/data processing
> Affects Versions: 0.5
> Reporter: Michael Joyce
> Assignee: Michael Joyce
> Fix For: 1.0.0
>
>
> CLIMATE-463 introduced duplicated code for unit updates in datasets. This
> ticket is for cleaning that up.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
