[
https://issues.apache.org/jira/browse/CLIMATE-768?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15169490#comment-15169490
]
ASF GitHub Bot commented on CLIMATE-768:
----------------------------------------
GitHub user MichaelArthurAnderson opened a pull request:
https://github.com/apache/climate/pull/313
CLIMATE-768 - Fix failing tests in test_dap.py. Add extra logic to dap.py
to check for named dimensions.
1. Fix various Pylint complaints on dap.py and test_dap.py.
2. Add extra logic to dap.py to inspect the dimensions list rather than
just assuming time / lat / lon are the first three dimensions.
3. Update the test cases to reflect the values found in the new test file
added in CLIMATE-757.
4. Update the name of the set up function in test_dap.py to ensure set up
is called before executing tests.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/MichaelArthurAnderson/climate CLIMATE-768
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/climate/pull/313.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #313
----
commit de190c6d7c562c87eadf2ce2645fa744f379f4bf
Author: MichaelArthurAnderson <[email protected]>
Date: 2016-02-26T18:23:58Z
CLIMATE-768 - Fix failing tests in test_dap.py. Add extra logic to dap.py
to check for named dimensions.
commit 4e36c1db769959b870f4e49355731e19388c92d3
Author: MichaelArthurAnderson <[email protected]>
Date: 2016-02-26T18:28:46Z
CLIMATE-768 - Fix failing tests in test_dap.py. Add extra logic to dap.py
to check for named dimensions.
----
> test_dap.py Tests Failing
> -------------------------
>
> Key: CLIMATE-768
> URL: https://issues.apache.org/jira/browse/CLIMATE-768
> Project: Apache Open Climate Workbench
> Issue Type: Bug
> Reporter: Michael Anderson
> Priority: Trivial
>
> test_dap test cases are failing.
> 1. Set up function not being called. Rename set up function to follow
> standard naming convention.
> 2. Expected results are not consistent with new test file.
> 3. Clean up Pylint in dap.py and test_dap.py.
> 4. Update dap.py to account for the convention of time / height / lat / lon.
> Family-Room-iMac:tests michaelanderson$ python test_dap.py
> FFF...F
> ======================================================================
> FAIL: test_correct_lat_shape (__main__.TestDap)
> ----------------------------------------------------------------------
> Traceback (most recent call last):
> File "test_dap.py", line 34, in test_correct_lat_shape
> self.assertEquals(len(self.dataset.lats), 89)
> AssertionError: 29 != 89
> ======================================================================
> FAIL: test_correct_lon_shape (__main__.TestDap)
> ----------------------------------------------------------------------
> Traceback (most recent call last):
> File "test_dap.py", line 37, in test_correct_lon_shape
> self.assertEquals(len(self.dataset.lons), 180)
> AssertionError: 26 != 180
> ======================================================================
> FAIL: test_correct_time_shape (__main__.TestDap)
> ----------------------------------------------------------------------
> Traceback (most recent call last):
> File "test_dap.py", line 40, in test_correct_time_shape
> self.assertEquals(len(self.dataset.times), 1857)
> AssertionError: 1 != 1857
> ======================================================================
> FAIL: test_valid_date_conversion (__main__.TestDap)
> ----------------------------------------------------------------------
> Traceback (most recent call last):
> File "test_dap.py", line 44, in test_valid_date_conversion
> self.assertTrue(start == self.dataset.times[0])
> AssertionError: False is not true
> ----------------------------------------------------------------------
> Ran 7 tests in 3.264s
> FAILED (failures=4)
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
