My concern is that it will only fix the problem 90% of the time, because we didn't wait 4 seconds. Then we bump it to 5, or 10, and needlessly delay the boot up. Its far better to take a few lines of code to verify you're ready before continuing than assume that some number of seconds is always enough. On Mar 21, 2013 12:27 PM, "Anthony Urso" <antho...@cs.ucla.edu> wrote:
> This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/10060/ > > Ship it! > > If this solves the problem, it's better to do it in this simple way than add > the extra complexity of the timer loop. > > > - Anthony > > On March 21st, 2013, 12:44 p.m., Jayapal Reddy wrote: > Review request for cloudstack, Anthony Urso, Abhinandan Prateek, edison > su, Rohit Yadav, and Marcus Sorensen. > By Jayapal Reddy. > > *Updated March 21, 2013, 12:44 p.m.* > Description > > Added sleep in cloud-early-config before adding route > > Testing > > Tested for ssvm, cpvm and router. Default route added properly > > *Bugs: * CLOUDSTACK-1565 > Diffs > > - patches/systemvm/debian/config/etc/init.d/cloud-early-config > (1f0b9a7) > > View Diff <https://reviews.apache.org/r/10060/diff/> >
