----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/10393/#review19057 -----------------------------------------------------------
test/integration/smoke/1 <https://reviews.apache.org/r/10393/#comment39607> This file was probably added unintentionally. Can you remove it? test/integration/smoke/test_volumes.py <https://reviews.apache.org/r/10393/#comment39608> Why would a sleep be required here? Can you add a comment for why? test/integration/smoke/test_volumes.py <https://reviews.apache.org/r/10393/#comment39609> This sleep can also be removed since virtual_machine.stop returns only after the VM moves to stopped state. test/integration/smoke/test_volumes.py <https://reviews.apache.org/r/10393/#comment39610> Same as above. - Prasanna Santhanam On April 12, 2013, 6:35 a.m., SrikanteswaraRao Talluri wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/10393/ > ----------------------------------------------------------- > > (Updated April 12, 2013, 6:35 a.m.) > > > Review request for cloudstack, Prasanna Santhanam and Marcus Sorensen. > > > Description > ------- > > Based on hypervisor, resizeVolume needs VM to be in stopped state for > xenserver. > > Earlier tests had volume not attached, Hence, resize is failing > > > This addresses bug CLOUDSTACK-1995. > > > Diffs > ----- > > test/integration/smoke/1 PRE-CREATION > test/integration/smoke/test_volumes.py 36eb5de > > Diff: https://reviews.apache.org/r/10393/diff/ > > > Testing > ------- > > Tested with KVM and XenServer hypervisors with local storage. I couldn't test > on shared storage because of a bug related to primary storage > > > Thanks, > > SrikanteswaraRao Talluri > >
