> On April 12, 2013, 8:33 a.m., Prasanna Santhanam wrote: > > test/integration/smoke/test_volumes.py, line 570 > > <https://reviews.apache.org/r/10393/diff/1/?file=280213#file280213line570> > > > > Why would a sleep be required here? Can you add a comment for why?
removed it > On April 12, 2013, 8:33 a.m., Prasanna Santhanam wrote: > > test/integration/smoke/test_volumes.py, line 576 > > <https://reviews.apache.org/r/10393/diff/1/?file=280213#file280213line576> > > > > This sleep can also be removed since virtual_machine.stop returns only > > after the VM moves to stopped state. removed it > On April 12, 2013, 8:33 a.m., Prasanna Santhanam wrote: > > test/integration/smoke/test_volumes.py, line 612 > > <https://reviews.apache.org/r/10393/diff/1/?file=280213#file280213line612> > > > > Same as above. removed it - SrikanteswaraRao ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/10393/#review19057 ----------------------------------------------------------- On April 15, 2013, 6:08 a.m., SrikanteswaraRao Talluri wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/10393/ > ----------------------------------------------------------- > > (Updated April 15, 2013, 6:08 a.m.) > > > Review request for cloudstack, Prasanna Santhanam and Marcus Sorensen. > > > Description > ------- > > Based on hypervisor, resizeVolume needs VM to be in stopped state for > xenserver. > > Earlier tests had volume not attached, Hence, resize is failing > > > This addresses bug CLOUDSTACK-1995. > > > Diffs > ----- > > test/integration/smoke/test_volumes.py 36eb5de > > Diff: https://reviews.apache.org/r/10393/diff/ > > > Testing > ------- > > Tested with KVM and XenServer hypervisors with local storage. I couldn't test > on shared storage because of a bug related to primary storage > > > Thanks, > > SrikanteswaraRao Talluri > >
