----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/11435/#review21069 -----------------------------------------------------------
server/src/com/cloud/configuration/ConfigurationManagerImpl.java <https://reviews.apache.org/r/11435/#comment43583> There are multiple return paths for this method. How are you ensuring consistency in the db. for all the return paths? The complexity of the code makes the testing very difficult server/src/com/cloud/configuration/ConfigurationManagerImpl.java <https://reviews.apache.org/r/11435/#comment43577> unused server/src/com/cloud/configuration/ConfigurationManagerImpl.java <https://reviews.apache.org/r/11435/#comment43580> First check if log level is debug and then only print the message. Do in other places as well server/src/com/cloud/configuration/ConfigurationManagerImpl.java <https://reviews.apache.org/r/11435/#comment43579> There are multiple db calls _vlanDao, _nicIpAliasDao, _publicIpAddressDao. What happens in case of partial success? Should this be in a txn? server/src/com/cloud/configuration/ConfigurationManagerImpl.java <https://reviews.apache.org/r/11435/#comment43582> In some cases you are throwing and in some case you are returning boolean? What is the logic? server/src/com/cloud/configuration/ConfigurationManagerImpl.java <https://reviews.apache.org/r/11435/#comment43581> there is a return, what happens to the txn? server/src/com/cloud/network/router/VirtualNetworkApplianceManagerImpl.java <https://reviews.apache.org/r/11435/#comment43571> why is the error message add/remove vpn users? Also what is the account and zone here server/src/com/cloud/network/router/VirtualNetworkApplianceManagerImpl.java <https://reviews.apache.org/r/11435/#comment43574> unused server/src/com/cloud/network/router/VirtualNetworkApplianceManagerImpl.java <https://reviews.apache.org/r/11435/#comment43573> Is it possible that some routers are running and some are not? If so what happens? server/src/com/cloud/network/router/VirtualNetworkApplianceManagerImpl.java <https://reviews.apache.org/r/11435/#comment43572> error message: same as above server/src/com/cloud/network/router/VirtualNetworkApplianceManagerImpl.java <https://reviews.apache.org/r/11435/#comment43575> message says apply but this for revoke. right? also dhcp has become "dhco" server/src/com/cloud/network/router/VirtualNetworkApplianceManagerImpl.java <https://reviews.apache.org/r/11435/#comment43576> dhco -> dhcp - Koushik Das On May 27, 2013, 2:50 p.m., bharat kumar wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/11435/ > ----------------------------------------------------------- > > (Updated May 27, 2013, 2:50 p.m.) > > > Review request for cloudstack, Abhinandan Prateek and Koushik Das. > > > Description > ------- > > [Multiple_IP_Ranges] Failed to delete guest IP range from a new subnet/C > https://issues.apache.org/jira/browse/CLOUDSTACK-2621 > > > This addresses bug Cloudstack-2621. > > > Diffs > ----- > > server/src/com/cloud/configuration/ConfigurationManagerImpl.java 214e292 > server/src/com/cloud/network/router/VirtualNetworkApplianceManagerImpl.java > b969be2 > > Diff: https://reviews.apache.org/r/11435/diff/ > > > Testing > ------- > > tested on master. > > > Thanks, > > bharat kumar > >
