----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/11435/#review21688 -----------------------------------------------------------
server/src/com/cloud/configuration/ConfigurationManagerImpl.java <https://reviews.apache.org/r/11435/#comment44818> Where is the txn started? Where is the txn marked as complete? server/src/com/cloud/configuration/ConfigurationManagerImpl.java <https://reviews.apache.org/r/11435/#comment44817> nit: handel -> handle server/src/com/cloud/configuration/ConfigurationManagerImpl.java <https://reviews.apache.org/r/11435/#comment44833> Move this comment to the place where the code is moved server/src/com/cloud/configuration/ConfigurationManagerImpl.java <https://reviews.apache.org/r/11435/#comment44835> Instead of using _accountDao.findById(Account.ACCOUNT_ID_SYSTEM) why don't you pass the 'caller' parameter from the calling function server/src/com/cloud/configuration/ConfigurationManagerImpl.java <https://reviews.apache.org/r/11435/#comment44837> result_final is set to false, but the code is still moving ahead. Previously there was a return So the remaining code should only be executed if (result == true). - Koushik Das On June 3, 2013, 10:27 a.m., bharat kumar wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/11435/ > ----------------------------------------------------------- > > (Updated June 3, 2013, 10:27 a.m.) > > > Review request for cloudstack, Abhinandan Prateek and Koushik Das. > > > Description > ------- > > [Multiple_IP_Ranges] Failed to delete guest IP range from a new subnet/C > https://issues.apache.org/jira/browse/CLOUDSTACK-2621 > > > This addresses bug Cloudstack-2621. > > > Diffs > ----- > > server/src/com/cloud/configuration/ConfigurationManagerImpl.java 59e70cf > server/src/com/cloud/network/router/VirtualNetworkApplianceManagerImpl.java > c71d037 > > Diff: https://reviews.apache.org/r/11435/diff/ > > > Testing > ------- > > tested on master. > > > Thanks, > > bharat kumar > >
