----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/12241/#review22705 -----------------------------------------------------------
test/integration/component/test_network_offering.py <https://reviews.apache.org/r/12241/#comment46407> There is a different issue here. specifyVlan=false is the default behaviour of the API. But the network used for creation specifies the vlan. The test should be for creating the most basic network out of a standard network offering where specifyVlan=false and no vlan is given. The test case for specifying a vlan should be separated. - Prasanna Santhanam On July 3, 2013, 7:03 a.m., Girish Shilamkar wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/12241/ > ----------------------------------------------------------- > > (Updated July 3, 2013, 7:03 a.m.) > > > Review request for cloudstack and Prasanna Santhanam. > > > Repository: cloudstack-git > > > Description > ------- > > Tests in test_network_offering.py failed as Vlan option was false. Changed it > to true. > > > Diffs > ----- > > test/integration/component/test_network_offering.py a3e87f6 > > Diff: https://reviews.apache.org/r/12241/diff/ > > > Testing > ------- > > > Thanks, > > Girish Shilamkar > >
