----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/12509/#review23084 -----------------------------------------------------------
Ship it! applied cleanly to ldapplugin branch 215aa0372baafc28461e8e1b1fd25c258bfa8ed4 mark review as submitted thx - Sebastien Goasguen On July 12, 2013, 12:20 p.m., Ian Duffy wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/12509/ > ----------------------------------------------------------- > > (Updated July 12, 2013, 12:20 p.m.) > > > Review request for cloudstack, Abhinandan Prateek and Sebastien Goasguen. > > > Repository: cloudstack-git > > > Description > ------- > > Adds a integration test for the LDAP plugin. > Inserts the apache license on all newly created files relating to my work > excluding LdapAddConfiguration.java(Kept getting an error when attempting to > upload a patch that modified that file). > > > Diffs > ----- > > > plugins/user-authenticators/ldap/src/org/apache/cloudstack/api/command/LdapDeleteConfigurationCmd.java > 364b260 > > plugins/user-authenticators/ldap/src/org/apache/cloudstack/api/command/LdapListAllUsersCmd.java > f261f74 > > plugins/user-authenticators/ldap/src/org/apache/cloudstack/api/command/LdapListConfigurationCmd.java > d3239e6 > > plugins/user-authenticators/ldap/src/org/apache/cloudstack/api/command/LdapUserSearchCmd.java > a8d3308 > > plugins/user-authenticators/ldap/src/org/apache/cloudstack/api/response/LdapConfigurationResponse.java > 12c6ed9 > > plugins/user-authenticators/ldap/src/org/apache/cloudstack/api/response/LdapUserResponse.java > 24d8b4d > > plugins/user-authenticators/ldap/src/org/apache/cloudstack/ldap/LdapAuthenticator.java > 74a15b6 > > plugins/user-authenticators/ldap/src/org/apache/cloudstack/ldap/LdapConfiguration.java > 07d4879 > > plugins/user-authenticators/ldap/src/org/apache/cloudstack/ldap/LdapConfigurationVO.java > e7fe0a9 > > plugins/user-authenticators/ldap/src/org/apache/cloudstack/ldap/LdapContextFactory.java > 918fd20 > > plugins/user-authenticators/ldap/src/org/apache/cloudstack/ldap/LdapManager.java > 980beb7 > > plugins/user-authenticators/ldap/src/org/apache/cloudstack/ldap/LdapManagerImpl.java > 77dd33e > > plugins/user-authenticators/ldap/src/org/apache/cloudstack/ldap/LdapUser.java > 046447f > > plugins/user-authenticators/ldap/src/org/apache/cloudstack/ldap/LdapUserManager.java > e53a320 > > plugins/user-authenticators/ldap/src/org/apache/cloudstack/ldap/LdapUtils.java > d7c4831 > > plugins/user-authenticators/ldap/src/org/apache/cloudstack/ldap/NoLdapUserMatchingQueryException.java > 3194653 > > plugins/user-authenticators/ldap/src/org/apache/cloudstack/ldap/NoSuchLdapUserException.java > c089664 > > plugins/user-authenticators/ldap/src/org/apache/cloudstack/ldap/dao/LdapConfigurationDao.java > 14f9947 > > plugins/user-authenticators/ldap/src/org/apache/cloudstack/ldap/dao/LdapConfigurationDaoImpl.java > eaeae99 > > plugins/user-authenticators/ldap/test/groovy/org/apache/cloudstack/ldap/BasicNamingEnumerationImpl.groovy > 6dd81b8 > > plugins/user-authenticators/ldap/test/groovy/org/apache/cloudstack/ldap/LdapAddConfigurationCmdSpec.groovy > 225d660 > > plugins/user-authenticators/ldap/test/groovy/org/apache/cloudstack/ldap/LdapAuthenticatorSpec.groovy > 912df30 > > plugins/user-authenticators/ldap/test/groovy/org/apache/cloudstack/ldap/LdapConfigurationDaoImplSpec.groovy > 2ceae5d > > plugins/user-authenticators/ldap/test/groovy/org/apache/cloudstack/ldap/LdapConfigurationResponseSpec.groovy > 899267a > > plugins/user-authenticators/ldap/test/groovy/org/apache/cloudstack/ldap/LdapConfigurationSpec.groovy > c0208a8 > > plugins/user-authenticators/ldap/test/groovy/org/apache/cloudstack/ldap/LdapConfigurationVO.groovy > dabf805 > > plugins/user-authenticators/ldap/test/groovy/org/apache/cloudstack/ldap/LdapContextFactorySpec.groovy > 1f97012 > > plugins/user-authenticators/ldap/test/groovy/org/apache/cloudstack/ldap/LdapDeleteConfigurationCmdSpec.groovy > 31a2047 > > plugins/user-authenticators/ldap/test/groovy/org/apache/cloudstack/ldap/LdapListAllUsersCmdSpec.groovy > ee0808e > > plugins/user-authenticators/ldap/test/groovy/org/apache/cloudstack/ldap/LdapListConfigurationCmdSpec.groovy > c3ca237 > > plugins/user-authenticators/ldap/test/groovy/org/apache/cloudstack/ldap/LdapManagerImplSpec.groovy > 689c52b > > plugins/user-authenticators/ldap/test/groovy/org/apache/cloudstack/ldap/LdapSearchUserCmdSpec.groovy > 64f55c3 > > plugins/user-authenticators/ldap/test/groovy/org/apache/cloudstack/ldap/LdapUserManagerSpec.groovy > 1ee7d6f > > plugins/user-authenticators/ldap/test/groovy/org/apache/cloudstack/ldap/LdapUserResponseSpec.groovy > f96f33d > > plugins/user-authenticators/ldap/test/groovy/org/apache/cloudstack/ldap/LdapUserSpec.groovy > 1293a0e > > plugins/user-authenticators/ldap/test/groovy/org/apache/cloudstack/ldap/LdapUtilsSpec.groovy > 3133493 > > plugins/user-authenticators/ldap/test/groovy/org/apache/cloudstack/ldap/NoLdapUserMatchingQueryExceptionSpec.groovy > e2b78dd > > plugins/user-authenticators/ldap/test/groovy/org/apache/cloudstack/ldap/NoSuchLdapUserExceptionSpec.groovy > ece8d4b > test/integration/component/test_ldap.py fc3bd48 > > Diff: https://reviews.apache.org/r/12509/diff/ > > > Testing > ------- > > The integration test was executed against a windows active directory server. > > The following command was used to execute the test: > > nosetests --with-marvin --marvin-config=setup/dev/local.cfg > test/integration/component/test_ldap.py --load > > > Thanks, > > Ian Duffy > >
