-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/12547/#review23155
-----------------------------------------------------------

Ship it!


Applied to your branch:

commit c50d9fece03c2eec1037416d5df74b2a6412b769
Author: Ian Duffy <[email protected]>
Date:   Mon Jul 15 13:25:48 2013 +0100

    Add embedded ldap server for running integration tests against

- Chip Childers


On July 15, 2013, 12:39 p.m., Ian Duffy wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/12547/
> -----------------------------------------------------------
> 
> (Updated July 15, 2013, 12:39 p.m.)
> 
> 
> Review request for cloudstack, Abhinandan Prateek and Sebastien Goasguen.
> 
> 
> Repository: cloudstack-git
> 
> 
> Description
> -------
> 
> Added an embedded LDAP server that uses ApacheDS for integration tests. 
> The implementation has been provided by this maven plugin: 
> http://ldap-maven-plugin.btmatthews.com/
> 
> Added a sample LDIF dump to import into the LDAP server for integration tests.
> 
> The LDAP server can be brought up with:
> mvn -pl :cloud-plugin-user-authenticator-ldap ldap:run
> 
> 
> Diffs
> -----
> 
>   plugins/user-authenticators/ldap/pom.xml 8ea67fe 
>   plugins/user-authenticators/ldap/test/resources/cloudstack.org.ldif 
> PRE-CREATION 
>   test/integration/component/test_ldap.py ec7987c 
> 
> Diff: https://reviews.apache.org/r/12547/diff/
> 
> 
> Testing
> -------
> 
> 1) Brought up the embedded LDAP server. Confirmed that it gets populated as 
> expected by querying it with ldap search, ldapsearch -h localhost -b 
> dc=cloudstack,dc=org -xxx
> 
> 2) Brought up the jetty server and the embedded LDAP server and executed the 
> integration test. It executed successfully.
> 
> 
> Thanks,
> 
> Ian Duffy
> 
>

Reply via email to