----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/12629/#review23499 -----------------------------------------------------------
Commit 5de96db81d666a680f99e0a719ef79794c6358ff in branch refs/heads/4.2 from Sanjay Tripathi [ https://git-wip-us.apache.org/repos/asf?p=cloudstack.git;h=5de96db ] CLOUDSTACK-3492: [Regression]Update Resource Count for an account is updating the primary storage incorretly. The issue is that while calculating the used primary storage size, the updateResourceCount API is also calculating the disk size of virtual router VM, created for that account and because of this, the API is returning the incorrect result. - ASF Subversion and Git Services On July 17, 2013, 5:11 a.m., Sanjay Tripathi wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/12629/ > ----------------------------------------------------------- > > (Updated July 17, 2013, 5:11 a.m.) > > > Review request for cloudstack and Devdeep Singh. > > > Bugs: CLOUDSTACK-3492 > > > Repository: cloudstack-git > > > Description > ------- > > CLOUDSTACK-3492: [Regression]Update Resource Count for an account is updating > the primary storage incorretly. > > Steps: > > 1. Deploy instance with user account1 > 2. Get the primary storage is usage using ListAccounts- It is 10 GB same as > ROOT disk size of this instance > 3. Now tried Update Resource Count for this account. With this when verified > the usage using listAccounts it increased to 11 GB > > 4. Added one DATA disk of 5 GB . With which usage has become 16 GB > > 5. Then tried Update Resource Count for this account. With this when verified > the usage using listAccounts it decreased to 11 GB > > Observation : > Update Resource Count for an account is updating the primary storage > incorrectly (Attached API log) > > > Diffs > ----- > > engine/schema/src/com/cloud/storage/dao/VolumeDao.java fb7dc70 > engine/schema/src/com/cloud/storage/dao/VolumeDaoImpl.java ba85466 > engine/schema/src/com/cloud/vm/dao/VMInstanceDao.java e564052 > engine/schema/src/com/cloud/vm/dao/VMInstanceDaoImpl.java ec04085 > server/src/com/cloud/resourcelimit/ResourceLimitManagerImpl.java 5a9d360 > > Diff: https://reviews.apache.org/r/12629/diff/ > > > Testing > ------- > > Verified locally by following the steps mentioned in description. > > > Thanks, > > Sanjay Tripathi > >
