> On July 18, 2013, 11:09 a.m., Prasanna Santhanam wrote: > > Do you think you can add a integration test to test_explicit_dedication.py > > for this failure? That would be really useful to catch this part of tricky > > code
Prasanna the changes I have made are specifically related to alert generation, the original functionality is kept unchanged. Do you suggest to additional test that checks for alert generation ? - Saksham ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/12720/#review23372 ----------------------------------------------------------- On July 19, 2013, 11:52 a.m., Saksham Srivastava wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/12720/ > ----------------------------------------------------------- > > (Updated July 19, 2013, 11:52 a.m.) > > > Review request for cloudstack and Devdeep Singh. > > > Bugs: 3382 > > > Repository: cloudstack-git > > > Description > ------- > > Allow root admin to migrate VMs across dedicated hosts. > Generate alerts for each migration performed between dedicated hosts. > Alerts are generated for VM migration between: > 1) Source host is dedicated and destination host is not. > 2) Source host is not dedicated and destination host is dedicated. > 3) Both hosts are dedicated. > Alerts are now generated for both explicit and implicit dedication. > > > Diffs > ----- > > server/src/com/cloud/deploy/dao/PlannerHostReservationDao.java 69118f1 > server/src/com/cloud/deploy/dao/PlannerHostReservationDaoImpl.java 41e0964 > server/src/com/cloud/vm/UserVmManagerImpl.java 9968690 > > Diff: https://reviews.apache.org/r/12720/diff/ > > > Testing > ------- > > Migrated VMs across explicitly dedicated hosts and alerts are generated. > Migrated VMs across implicitly dedicated hosts and alerts are generated. > > > > Thanks, > > Saksham Srivastava > >
