fabiomatavelli commented on code in PR #71:
URL: 
https://github.com/apache/cloudstack-terraform-provider/pull/71#discussion_r1527183574


##########
.github/workflows/acceptance.yml:
##########
@@ -73,18 +81,35 @@ jobs:
       - name: Create extra resources
         run: |
           cmk -u $CLOUDSTACK_API_URL -k $CLOUDSTACK_API_KEY -s 
$CLOUDSTACK_SECRET_KEY -o json create project name=terraform 
displaytext=terraform
+      - uses: hashicorp/setup-terraform@v2
+        with:
+          terraform_version: ${{ matrix.terraform-version }}
+          terraform_wrapper: false
       - name: Run acceptance test
         run: |
           make testacc
     services:
       cloudstack-simulator:
-        image: apache/cloudstack-simulator:${{ matrix.cloudstack_version }}
+        image: apache/cloudstack-simulator:${{ matrix.cloudstack-version }}
         ports:
           - 8080:5050
     strategy:
       fail-fast: false
       matrix:
-        cloudstack_version:
+        terraform-version:
+          - '0.12.*'
+          - '0.13.*'
+          - '0.14.*'
+          - '0.15.*'
+          - '1.0.*'
+          - '1.1.*'
+          - '1.2.*'
+          - '1.3.*'
+          - '1.4.*'
+          - '1.5.*'
+          - '1.6.*'
+          - '1.7.*'

Review Comment:
   Does it make sense to test all the versions of terraform or only the non 
[EOL](https://support.hashicorp.com/hc/en-us/articles/360021185113-Support-Period-and-End-of-Life-EOL-Policy)?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Reply via email to