We just need to include it in the legal docs. It's compatible, but all external code and dependencies need to be accounted for.
I see that this is from the ASF actually, so adding it is easy. I'll take a look at doing it shortly. On Wed, Jul 24, 2013 at 2:28 PM, Frank Zhang <frank.zh...@citrix.com> wrote: > Amogh has checked it's Apache 2. I am not sure if any process we need to > go through > > > -----Original Message----- > > From: Chip Childers [mailto:chip.child...@sungard.com] > > Sent: Wednesday, July 24, 2013 11:24 AM > > To: dev@cloudstack.apache.org > > Subject: Re: Inclusion of commons-httpclient-contrib jar > > > > Nobody has bothered to deal with the LICENSE file for the file described > below. > > > > Anyone want to take this on, or at least give me the information > required? > > > > > > On Wed, Jul 24, 2013 at 05:59:59PM +0000, Frank Zhang wrote: > > > Agree. Amogh actually has done it in cloud-utils > > > > > > > -----Original Message----- > > > > From: Koushik Das [mailto:koushik....@citrix.com] > > > > Sent: Wednesday, July 24, 2013 10:26 AM > > > > To: dev@cloudstack.apache.org > > > > Subject: RE: Inclusion of commons-httpclient-contrib jar > > > > > > > > For now I think cloud-utils is the best option. > > > > > > > > > -----Original Message----- > > > > > From: Amogh Vasekar [mailto:amogh.vase...@citrix.com] > > > > > Sent: Wednesday, July 24, 2013 10:48 PM > > > > > To: dev@cloudstack.apache.org > > > > > Subject: Re: Inclusion of commons-httpclient-contrib jar > > > > > > > > > > Hi Alex, > > > > > > > > > > Thanks! I had looked at that initially, but found this disclaimer > > > > > on the source website : > > > > > "Warning: > > > > > not-yet-commons-ssl-0.3.11 should be considered to be of "Alpha" > > quality!" > > > > > > > > > > I do not see a code update in it for the past 4 years, and thus > was skeptical. > > > > > Please let me know if we should go ahead with it. > > > > > > > > > > Thanks, > > > > > Amogh > > > > > > > > > > On 7/23/13 10:51 PM, "Alex Huang" <alex.hu...@citrix.com> wrote: > > > > > > > > > > >Amogh, > > > > > > > > > > > >I added the following to the pom.xml for cisco and it seems to > > > > > >compile with a few extra exceptions try-catch added. Can you > > > > > >check on if you can use this? > > > > > > > > > > > ><dependency> > > > > > > <groupId>ca.juliusdavies</groupId> > > > > > > <artifactId>not-yet-commons-ssl</artifactId> > > > > > > <version>0.3.11</version> > > > > > ></dependency> > > > > > > > > > > > >--Alx > > > > > > > > > > > >> -----Original Message----- > > > > > >> From: Alex Huang [mailto:alex.hu...@citrix.com] > > > > > >> Sent: Tuesday, July 23, 2013 10:25 PM > > > > > >> To: dev@cloudstack.apache.org > > > > > >> Subject: RE: Inclusion of commons-httpclient-contrib jar > > > > > >> > > > > > >> Isn't this in commons-httpclient 3.1? > > > > > >> > > > > > >> http://grepcode.com/file/repo1.maven.org/maven2/commons- > > > > > >> httpclient/commons- > > > > > >> httpclient/3.1/org/apache/commons/httpclient/contrib/ssl/EasyX5 > > > > > >> 09Tr > > > > > >> us > > > > > >> tM > > > > > >> anager.java > > > > > >> > > > > > >> --Alex > > > > > >> > > > > > >> > -----Original Message----- > > > > > >> > From: Chiradeep Vittal [mailto:chiradeep.vit...@citrix.com] > > > > > >> > Sent: Tuesday, July 23, 2013 9:41 PM > > > > > >> > To: dev@cloudstack.apache.org > > > > > >> > Subject: Re: Inclusion of commons-httpclient-contrib jar > > > > > >> > > > > > > >> > +1 > > > > > >> > @Frank, it is not a re-implementation, but a copy. > > > > > >> > > > > > > >> > On 7/24/13 2:14 AM, "Amogh Vasekar" > > > > > >> > <amogh.vase...@citrix.com> > > > > > >> wrote: > > > > > >> > > > > > > >> > >In the absence of an officially published jar on maven for > > > > > >> > >contrib-ssl, the current idea is to put this package in > > > > > >> > >cloud-utils (it is a dependency for both cisco-vnmc and ucs) > > > > > >> > >for easier > > > > > >>maintenance. > > > > > >> > >Please let me know if this sounds good. > > > > > >> > > > > > > > >> > >Thanks, > > > > > >> > >Amogh > > > > > >> > > > > > > > >> > >On 7/22/13 5:26 PM, "Frank Zhang" <frank.zh...@citrix.com> > > wrote: > > > > > >> > > > > > > > >> > >>I prefer to just use httpclient-contribs.jar as it has been > > > > > >> > >>proven by lots of users. > > > > > >> > >>Reimplementing such code brings no gain but maintenance > effort. > > > > > >> > >> > > > > > >> > >>> -----Original Message----- > > > > > >> > >>> From: Amogh Vasekar [mailto:amogh.vase...@citrix.com] > > > > > >> > >>> Sent: Monday, July 22, 2013 5:17 PM > > > > > >> > >>> To: dev@cloudstack.apache.org > > > > > >> > >>> Subject: Inclusion of commons-httpclient-contrib jar > > > > > >> > >>> > > > > > >> > >>> Hi All, > > > > > >> > >>> > > > > > >> > >>> I was working on a HTTPS related fix, and found this > > > > > >> > >>>package in the codebase : > > > > > >> > >>> > > > > > >> > >>> > > > > > https://github.com/apache/cloudstack/tree/master/plugins/networ > > > > > >> > >>> k- > > > > > >> > >>> elements/c > > > > > >> > >>> isco-vnmc/src/org/apache/commons/httpclient/contrib/ssl > > > > > >> > >>> > > > > > >> > >>> I need to use the same classes, which are already a part > > > > > >> > >>>of httpclient-contribs jar > > > > > >> > >>> > > > > > >> > > > > > > >>>(http://www.java2s.com/Code/Jar/c/Downloadcommonshttpclientcon > > > > > >> tr > > > > > >> > ib31jar. > > > > > >> > >>> htm > > > > > >> > >>> ) > > > > > >> > >>> > > > > > >> > >>> Was wondering if there is a specific reason the jar was > > > > > >> > >>>not included instead (probably since it is a contrib > > > > > >> > >>>jar?) > > > > > >> > >>> > > > > > >> > >>> Thanks, > > > > > >> > >>> Amogh > > > > > >> > >> > > > > > >> > > > > > > > > > > > > > > > >
