----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/12025/#review23815 -----------------------------------------------------------
Commit 80ac885e22b19dc2f7a0a9ba8b02b0911f32a9f3 in branch refs/heads/master from Edison Su [ https://git-wip-us.apache.org/repos/asf?p=cloudstack.git;h=80ac885 ] CLOUDSTACK-2304: fix migrate volume for vmware - ASF Subversion and Git Services On June 21, 2013, 12:32 p.m., Rajesh Battala wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/12025/ > ----------------------------------------------------------- > > (Updated June 21, 2013, 12:32 p.m.) > > > Review request for cloudstack, Alex Huang, edison su, Ram Ganesh, and Sateesh > Chodapuneedi. > > > Bugs: CLOUDSTACK-2304 > > > Repository: cloudstack-git > > > Description > ------- > > Issue : while migrating the volume from one ZWPS to another ZWPS then NPE is > having which is failing the migration of volume > Fixed: The issue is, if the volume is in ZWPS then the volume object won't be > having podid. > while volume migration, ZWPS specific volume cases are not handled. > Fixed the issues by adding a new constructor in VolumeVO and taken > care in VolumeServiceImpl to handle ZWPS volume while migration. > > > Diffs > ----- > > engine/schema/src/com/cloud/storage/VolumeVO.java 02c09a2 > > engine/storage/volume/src/org/apache/cloudstack/storage/volume/VolumeServiceImpl.java > 1d36f93 > > Diff: https://reviews.apache.org/r/12025/diff/ > > > Testing > ------- > > Setup: > Create a KVM cluster and add zwps to the primary storage. ZWPS got mounted on > KVM. Created instances in KVM. > 1. Create a Volume and attach the volume to the running VM. volume got > successfully attached to the VM. > 2. Detach the Volume and then try to Migrate the Volume to another ZWPS added > to the ZONE. volume got migrated successfully to another ZWPS. > Observed Volume got copied to the new ZWPS and then the old volume is > deleted. > Verified db, the volume uuid got updated and necessary fields. > > Addition Testing: > ================ > Created Xenserver cluster add cluster scope storage. > 1. create a volume and attach the instance running in Xenserver. Success. > 2. detach the volume and try to migrate the volume to another cluster scope > storage. Volume got successfully migrate to another storage. > Observed Volume got copied to the new PS and then the old volume is > deleted. > Verified db, the volume uuid got updated and necessary fields. > > > Thanks, > > Rajesh Battala > >
