CodeBleu commented on PR #77: URL: https://github.com/apache/cloudstack-terraform-provider/pull/77#issuecomment-2307047908
> @poddm The build is failing. Please check. Also, I am not sure about removing existing resource types. This can cause issues for users during an upgrade. I haven't completely checked, but the end user who will be upgrading the provider will have to migrate his existing terraform setup. @vishesh92 I don't believe the comment about "removing existing resource types" is what you think. I understood it to mean he would remove his changes in this PR that are not related to the "service offerings" resource. Also, @poddm if we are moving forward with your approach, can we use the new terraform plugin framework approach? #113 I think we should start moving to using that for new/updated resources. Then eventually we can get to upgrading the rest to use the new framework. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
