Copilot commented on code in PR #541:
URL: 
https://github.com/apache/cloudstack-documentation/pull/541#discussion_r2279113774


##########
source/adminguide/virtual_machines.rst:
##########
@@ -1265,6 +1265,19 @@ When the snapshotting is complete, the Instance is 
thawed.
 
 You can use this functionality on Instances with raw block storages (E.g. 
Ceph/SolidFire/Linstor).
 
+Disk-only File-based Storage Instance Snapshot on KVM
+-----------------------------------------------------
+
+Since version 4.21, CloudStack supports incremental disk-only instance 
snapshots for VMs on KVM that are running on file-based storages (NFS, local, 
shared-mount-point).
+Different from :ref:`Storage-based-Instance-Snapshots-on-KVM`, the VM is not 
frozen by default; only if the ``quiescevm`` parameter is informed. 
Furthermore, if ``quiescevm`` is true
+the VM is only frozen during the operation of creating the deltas on the 
volumes of the VM, thus the downtime is minimal.
+
+When using this snapshot strategy, you will not be able to create volume 
snapshots, as these two features are not compatible. If you want to use both 
volume snapshots and instance snapshots
+at the same time, you may inform the value 
``KvmFileBasedStorageVmSnapshotStrategy`` on the 
``vmSnapshot.strategies.exclude`` configuration, so that 

Review Comment:
   The phrase 'you may inform the value' is awkward. Consider using 'you can 
specify the value' or 'you can set the value' for clearer technical 
documentation.
   ```suggestion
   at the same time, you can specify the value 
``KvmFileBasedStorageVmSnapshotStrategy`` on the 
``vmSnapshot.strategies.exclude`` configuration, so that 
   ```



##########
source/adminguide/virtual_machines.rst:
##########
@@ -1265,6 +1265,19 @@ When the snapshotting is complete, the Instance is 
thawed.
 
 You can use this functionality on Instances with raw block storages (E.g. 
Ceph/SolidFire/Linstor).
 
+Disk-only File-based Storage Instance Snapshot on KVM
+-----------------------------------------------------
+
+Since version 4.21, CloudStack supports incremental disk-only instance 
snapshots for VMs on KVM that are running on file-based storages (NFS, local, 
shared-mount-point).

Review Comment:
   [nitpick] The term 'shared-mount-point' should use consistent hyphenation. 
Consider using 'shared mount point' or 'shared-mount point' for better 
readability.
   ```suggestion
   Since version 4.21, CloudStack supports incremental disk-only instance 
snapshots for VMs on KVM that are running on file-based storages (NFS, local, 
shared mount point).
   ```



##########
source/adminguide/virtual_machines.rst:
##########
@@ -1265,6 +1265,19 @@ When the snapshotting is complete, the Instance is 
thawed.
 
 You can use this functionality on Instances with raw block storages (E.g. 
Ceph/SolidFire/Linstor).
 
+Disk-only File-based Storage Instance Snapshot on KVM
+-----------------------------------------------------
+
+Since version 4.21, CloudStack supports incremental disk-only instance 
snapshots for VMs on KVM that are running on file-based storages (NFS, local, 
shared-mount-point).
+Different from :ref:`Storage-based-Instance-Snapshots-on-KVM`, the VM is not 
frozen by default; only if the ``quiescevm`` parameter is informed. 
Furthermore, if ``quiescevm`` is true

Review Comment:
   The phrase 'parameter is informed' is awkward. Consider using 'parameter is 
provided' or 'parameter is specified' for clearer technical documentation.
   ```suggestion
   Different from :ref:`Storage-based-Instance-Snapshots-on-KVM`, the VM is not 
frozen by default; only if the ``quiescevm`` parameter is provided. 
Furthermore, if ``quiescevm`` is true
   ```



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Reply via email to