Copilot commented on code in PR #305:
URL:
https://github.com/apache/cloudstack-terraform-provider/pull/305#discussion_r3633674896
##########
website/docs/r/vpn_connection.html.markdown:
##########
@@ -36,3 +36,11 @@ The following arguments are supported:
The following attributes are exported:
* `id` - The ID of the VPN Connection.
+
+## Import
+
+VPN Connections can be imported using the `id`, e.g.
+
+```shell
+$ terraform import cloudstack_vpn_connection.default
eb22f91-7454-4107-89f4-36afcdf33021
Review Comment:
The import example uses an invalid UUID format (the first segment is 7
characters). This can confuse users copying the command; use a valid UUID
example (consistent with other docs in this repo).
##########
website/docs/r/counter.html.markdown:
##########
@@ -41,3 +41,11 @@ The following arguments are supported:
The following attributes are exported:
* `id` - The counter ID.
+
+## Import
+
+Counters can be imported using the `id`, e.g.
+
+```shell
+$ terraform import cloudstack_counter.default
eb22f91-7454-4107-89f4-36afcdf33021
Review Comment:
The import example UUID is missing a character (7-char first segment), so it
doesn’t match the standard UUID format used elsewhere in the docs.
##########
cloudstack/resource_cloudstack_autoscale_vm_profile_test.go:
##########
@@ -85,6 +85,27 @@ func TestAccCloudStackAutoscaleVMProfile_update(t
*testing.T) {
})
}
+func TestAccCloudStackAutoscaleVMProfile_import(t *testing.T) {
+ t.Skip("Skipping due to bug in cloudstack-go library")
+
Review Comment:
This import acceptance test is unconditionally skipped, so the newly added
importer for `cloudstack_autoscale_vm_profile` isn’t actually exercised in CI.
If this is blocked by an upstream cloudstack-go issue, consider gating the skip
behind an env var and/or linking to the tracking issue so it can be re-enabled
when fixed.
##########
website/docs/r/autoscale_vm_profile.html.markdown:
##########
@@ -74,3 +74,11 @@ The following arguments are supported:
The following attributes are exported:
* `id` - The autoscale VM profile ID.
+
+## Import
+
+Autoscale VM profiles can be imported using the `id`, e.g.
+
+```shell
+$ terraform import cloudstack_autoscale_vm_profile.default
eb22f91-7454-4107-89f4-36afcdf33021
Review Comment:
The import example UUID appears to be missing a character (7 characters
before the first dash). Using a valid UUID format example would be clearer for
users.
##########
website/docs/r/autoscale_policy.html.markdown:
##########
@@ -61,3 +61,11 @@ The following arguments are supported:
The following attributes are exported:
* `id` - The autoscale policy ID.
+
+## Import
+
+Autoscale policies can be imported using the `id`, e.g.
+
+```shell
+$ terraform import cloudstack_autoscale_policy.default
eb22f91-7454-4107-89f4-36afcdf33021
Review Comment:
The import example UUID is not in a valid UUID format (7-character first
segment). This should be updated to a valid UUID example.
##########
website/docs/r/condition.html.markdown:
##########
@@ -59,3 +59,11 @@ The following arguments are supported:
The following attributes are exported:
* `id` - The condition ID.
+
+## Import
+
+Conditions can be imported using the `id`, e.g.
+
+```shell
+$ terraform import cloudstack_condition.default
eb22f91-7454-4107-89f4-36afcdf33021
Review Comment:
The import example uses a malformed UUID (first segment has 7 characters).
Consider using a valid UUID example to avoid copy/paste confusion.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
