dheeraj12347 commented on code in PR #219:
URL:
https://github.com/apache/cloudstack-cloudmonkey/pull/219#discussion_r3652065809
##########
config/cache.go:
##########
@@ -39,12 +39,13 @@ var bundledAPICache []byte
// APIArg are the args passable to an API
type APIArg struct {
- Name string
- Type string
- Related []string
- Description string
- Required bool
- Length int
+ Name string
+ Type string
+ Related []string
+ AllowedValues []string
Review Comment:
> any rationale to add it in the middle?
There wasn't a specific reason for placing it there. I grouped it near
Related since both are populated from the API discovery response, but I can
move AllowedValues to the end of the struct to keep the existing field ordering
consistent if that's preferred.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
