vishesh92 commented on code in PR #315:
URL:
https://github.com/apache/cloudstack-terraform-provider/pull/315#discussion_r3795433987
##########
cloudstack/service_offering_schema.go:
##########
@@ -237,6 +237,32 @@ func serviceOfferingMergeCommonSchema(s1
map[string]schema.Attribute) map[string
},
},
},
+ "gpu": schema.SingleNestedAttribute{
+ Optional: true,
+ Attributes: map[string]schema.Attribute{
+ "vgpu_profile_id": schema.StringAttribute{
+ Description: "the ID of the vGPU
profile to associate with the service offering",
+ Required: true,
+ PlanModifiers: []planmodifier.String{
+
stringplanmodifier.RequiresReplace(),
+ },
+ },
+ "count": schema.Int32Attribute{
+ Description: "the number of GPUs to
assign to the guest VM",
+ Optional: true,
Review Comment:
should we set a default value or computed here?
##########
cloudstack/service_offering_schema.go:
##########
@@ -237,6 +237,32 @@ func serviceOfferingMergeCommonSchema(s1
map[string]schema.Attribute) map[string
},
},
},
+ "gpu": schema.SingleNestedAttribute{
+ Optional: true,
+ Attributes: map[string]schema.Attribute{
+ "vgpu_profile_id": schema.StringAttribute{
+ Description: "the ID of the vGPU
profile to associate with the service offering",
+ Required: true,
+ PlanModifiers: []planmodifier.String{
+
stringplanmodifier.RequiresReplace(),
+ },
+ },
+ "count": schema.Int32Attribute{
+ Description: "the number of GPUs to
assign to the guest VM",
+ Optional: true,
+ PlanModifiers: []planmodifier.Int32{
+
int32planmodifier.RequiresReplace(),
+ },
+ },
+ "display": schema.BoolAttribute{
+ Description: "whether the GPU is
presented as a display device to the guest VM",
+ Optional: true,
+ PlanModifiers: []planmodifier.Bool{
Review Comment:
should we set a default value or computed here?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
