sudo87 commented on PR #323:
URL: 
https://github.com/apache/cloudstack-terraform-provider/pull/323#issuecomment-5315759093

   The ScaleVirtualMachine swap for service_offering looks correct, but I don't 
think this closes 
[#273](https://github.com/apache/cloudstack-terraform-provider/issues/273). The 
issue is specifically about the details map (cpuNumber/cpuSpeed/memory) — that 
update path (resourceCloudStackInstanceUpdate, d.HasChange("details") block) is 
untouched and still calls plain UpdateVirtualMachine, which only updates 
metadata without resizing the VM. Can this be extended to call 
ScaleVirtualMachine there too? Also, no tests were added for either path.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to