sudo87 commented on PR #323:
URL:
https://github.com/apache/cloudstack-terraform-provider/pull/323#issuecomment-5323647627
The panic/nil-safety fixes look good, thanks. But the core issue is still
open: `d.HasChange("details")` isn't in the outer "requires reboot" condition
(line ~692), so changing only `cpuNumber`/`cpuSpeed`/`memory` still skips
`ScaleVirtualMachine` and falls through to the old metadata-only
`UpdateVirtualMachine` path — this is the exact bug #273 reports, and it's been
flagged in the last few review passes. Can `details` be added to that
condition? Also, no test covers a `details`-only change, and the CPU/memory
assertions (`<= 0`) would pass even without scaling.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
