sudo87 commented on PR #297: URL: https://github.com/apache/cloudstack-terraform-provider/pull/297#issuecomment-5324800162
@elivlo I think this PR only fixes half of the issue. The same problem also occurs when cidr_list is empty. As @weizhouapache confirmed from the CloudStack source, an empty CIDR list gets rewritten to the network CIDR, just like 0.0.0.0/0: ``` Collections.replaceAll(sourceCidrs, "0.0.0.0/0", network.getCidr()); ``` Since cidr_list is optional and omitted when empty, CloudStack adds the network CIDR back, and Read then puts it into state. This results in a perpetual diff for configs where cidr_list is omitted. Could we also reject an empty cidr_list and add a test for this case? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
