Copilot commented on code in PR #222:
URL:
https://github.com/apache/cloudstack-cloudmonkey/pull/222#discussion_r3976599048
##########
.asf.yaml:
##########
@@ -30,6 +30,20 @@ github:
protected_branches:
main: {}
+ rulesets:
+ - name: "Default Branch Protection"
+ type: branch
+ branches:
+ includes:
+ - "~DEFAULT_BRANCH"
+ - "release/*"
Review Comment:
The PR title mentions protection rulesets for 'default and release
branches', but the added ruleset is named 'Default Branch Protection' and does
not appear to specify any release-branch targeting. If release branches are
intended to be covered, add an additional ruleset (or explicit targeting, if
supported by the ASF `.asf.yaml` schema) for release branch patterns;
otherwise, adjust the title/description to match the actual behavior.
##########
.asf.yaml:
##########
@@ -30,6 +30,20 @@ github:
protected_branches:
main: {}
+ rulesets:
+ - name: "Default Branch Protection"
+ type: branch
+ branches:
+ includes:
+ - "~DEFAULT_BRANCH"
+ - "release/*"
+ - "rel/*"
+ excludes: []
+ bypass_teams:
+ - root
+ restrict_deletion: true
Review Comment:
The PR description states 'nothing removed' and that existing settings 'stay
exactly as they are', but `copilot_code_review.review_drafts` and
`review_on_push` are changed from `true` to `false` (a functional behavior
change). Either revert these values to preserve existing behavior or update the
PR description (and rationale) to explicitly call out this change.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
