Copilot commented on code in PR #222:
URL:
https://github.com/apache/cloudstack-cloudmonkey/pull/222#discussion_r3976728685
##########
.asf.yaml:
##########
@@ -30,7 +30,15 @@ github:
protected_branches:
main: {}
+ rulesets:
+ - name: "Default Branch Protection"
+ type: branch
+ bypass_teams:
+ - root
+ restrict_deletion: true
+ restrict_force_push: true
Review Comment:
The PR title mentions 'default and release branches', but the added ruleset
is named 'Default Branch Protection' and (in this diff) does not show any
release-branch targeting. If release branches are intended to be protected
here, add the appropriate ruleset targeting for them (or adjust the
title/description if only the default branch is intended).
##########
.asf.yaml:
##########
@@ -30,7 +30,15 @@ github:
protected_branches:
main: {}
+ rulesets:
+ - name: "Default Branch Protection"
+ type: branch
+ bypass_teams:
+ - root
+ restrict_deletion: true
+ restrict_force_push: true
+
copilot_code_review:
enabled: true
- review_drafts: true
- review_on_push: true
+ review_drafts: false
+ review_on_push: false
Review Comment:
Switching `review_drafts` and `review_on_push` to `false` will
reduce/disable automated Copilot review activity compared to the previous
configuration. If the goal of this PR is strictly to add branch protection
rulesets without altering existing automation, keep these flags as `true` (or
document the rationale for turning them off).
##########
.asf.yaml:
##########
@@ -30,7 +30,15 @@ github:
protected_branches:
main: {}
+ rulesets:
+ - name: "Default Branch Protection"
+ type: branch
+ bypass_teams:
+ - root
+ restrict_deletion: true
+ restrict_force_push: true
+
copilot_code_review:
enabled: true
- review_drafts: true
- review_on_push: true
+ review_drafts: false
+ review_on_push: false
Review Comment:
The PR description says '14 lines added, nothing removed' and that existing
settings 'stay exactly as they are', but this diff changes existing
`copilot_code_review` behavior by flipping `review_drafts` and `review_on_push`
from `true` to `false`. Either update the PR description to reflect this
behavior change, or keep the original values.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
