borisstoyanov opened a new pull request, #221:
URL: https://github.com/apache/cloudstack-cloudmonkey/pull/221

   ### Problem
   
   The Apache RAT check has been failing on `main` since 9a04d5b (the #214 
merge):
   
   ```
   ! Unapproved:         1    A count of unapproved licenses.
   ! /cli/completer_test.go
   ```
   
   `cli/completer_test.go` landed in #214 without the ASF licence header, so 
RAT counts it as unapproved and the workflow's `Unapproved: 0` gate fails.
   
   ### Fix
   
   Add the standard 16-line ASF header, the same one every other `.go` file in 
the repo carries.
   
   ### Testing
   
   Ran the exact command from `.github/workflows/rat.yaml` locally with Apache 
RAT 0.18:
   
   ```
   java -jar apache-rat-0.18/apache-rat-0.18.jar -d . -E .rat-excludes
   ```
   
   - Before: `Unapproved: 1` — `/cli/completer_test.go`
   - After: `Unapproved: 0`
   
   Also `gofmt` clean, `go build ./...` OK, `go test ./...` passes.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to