dheeraj12347 opened a new pull request, #228:
URL: https://github.com/apache/cloudstack-cloudmonkey/pull/228
## Summary
Fixes #227.
Template uploads using `filepath=` failed in non-interactive mode because
`UploadFiles()` unconditionally used the CLI spinner.
`StartSpinner()` returns nil when CloudMonkey is running without a shell,
which caused a nil pointer dereference when the spinner was accessed.
This change:
- only creates the spinner when running interactively
- guards spinner operations when no spinner is available
- allows file uploads to continue normally in non-interactive mode
- adds a regression test that performs an actual multipart upload with
`HasShell=false`
## Validation
- `go test ./...` ✅
- `go vet ./...` ✅
- `git diff --check` ✅
- Regression test for non-interactive upload ✅
Fixes #227
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
