dheeraj12347 commented on PR #228: URL: https://github.com/apache/cloudstack-cloudmonkey/pull/228#issuecomment-5969879089
Hi @jl0815, @DaanHoogland I’ve opened PR #228 for #227. I traced the non-interactive template upload crash to UploadFiles() dereferencing a nil spinner when HasShell=false. The fix makes spinner handling optional while preserving interactive progress behavior, and I added a regression test that performs an actual multipart upload in non-interactive mode. go test ./..., go vet ./..., and git diff --check all pass. Would appreciate your review when you have time. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
