more review feedback for 12849?

[Daan Hoogland]

Is there more to say about
https://reviews.apache.org/r/12849/
?

Is it commit worthy? or if not what is missing?