Re: Review Request 14124: CLOUDSTACK-4622 : If a VM from guest network is added to network tier of VPC then IP reservation allows the CIDR to be a superset of Network CIDR for that VPC tier

[Saksham Srivastava]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/14124/
-----------------------------------------------------------

(Updated Dec. 9, 2013, 11:30 a.m.)


Review request for cloudstack and Sateesh Chodapuneedi.


Changes
-------

Updating a three month old patch as it was not applying cleanly on master.


Bugs: CLOUDSTACK-4622
    https://issues.apache.org/jira/browse/CLOUDSTACK-4622


Repository: cloudstack-git


Description
-------

Add a new utility method for comparing 2 CIDRs.
The method takes in 2 cidrs, cidrA and cidrB and returns true if cidrA's IP 
range is equal or a subset of cidrB's IP range.


Diffs (updated)
-----

  server/src/com/cloud/network/NetworkServiceImpl.java 6855587 
  utils/src/com/cloud/utils/net/NetUtils.java c0c792f 
  utils/test/com/cloud/utils/net/NetUtilsTest.java c7407bf 

Diff: https://reviews.apache.org/r/14124/diff/


Testing
-------

Added unit test for the utility.
Tested locally.
Build is successful.
Patch applies cleanly.


Thanks,

Saksham Srivastava