----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/14124/#review30904 -----------------------------------------------------------
Commit 07de75191c487de980be795b202b0a8d8bbda4d6 in branch refs/heads/master from Jayapal [ https://git-wip-us.apache.org/repos/asf?p=cloudstack.git;h=07de751 ] Revert "CLOUDSTACK-4622:If a VM from guest network is added to network tier of VPC then IP reservation allows the CIDR to be a superset of Network CIDR for that VPC tier" Reverting this commit as it is breaking vpc deployment, CLOUDSTACK-5652 This reverts commit ab4f095c68d4a4b4fb354b3d95096b193706987d. - ASF Subversion and Git Services On Dec. 24, 2013, 9:20 a.m., Saksham Srivastava wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/14124/ > ----------------------------------------------------------- > > (Updated Dec. 24, 2013, 9:20 a.m.) > > > Review request for cloudstack, Jayapal Reddy and Sateesh Chodapuneedi. > > > Bugs: CLOUDSTACK-4622 > https://issues.apache.org/jira/browse/CLOUDSTACK-4622 > > > Repository: cloudstack-git > > > Description > ------- > > Add a new utility method for comparing 2 CIDRs. > The method takes in 2 cidrs, cidrA and cidrB and returns true if cidrA's IP > range is equal or a subset of cidrB's IP range. > > > Diffs > ----- > > utils/src/com/cloud/utils/net/NetUtils.java f6f6285 > utils/test/com/cloud/utils/net/NetUtilsTest.java c7407bf > > Diff: https://reviews.apache.org/r/14124/diff/ > > > Testing > ------- > > Added unit test for the utility. > Tested locally. > Build is successful. > Patch applies cleanly. > > > Thanks, > > Saksham Srivastava > >
