-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/17591/
-----------------------------------------------------------
Review request for cloudstack.
Bugs: CLOUDSTACK-5872
https://issues.apache.org/jira/browse/CLOUDSTACK-5872
Repository: cloudstack-git
Description
-------
CLOUDSTACK-5872: Async response from addAccountToProject doesn't contain useful
information
Updated the following classes to return a project object after async jobs
complete:
api/src/com/cloud/projects/ProjectService.java | 6 ++--
.../user/account/AddAccountToProjectCmd.java | 7 +++--
.../user/account/DeleteAccountFromProjectCmd.java | 7 +++--
.../user/project/UpdateProjectInvitationCmd.java | 8 +++--
server/src/com/cloud/projects/ProjectManager.java | 2 +-
.../src/com/cloud/projects/ProjectManagerImpl.java | 34 +++++++++++-----------
.../com/cloud/projects/MockProjectManagerImpl.java | 16 +++++-----
Previously these API commands only returned "success => true" in the aysnc job
result. Now it returns the project that a user was added/deleted to.
Diffs
-----
api/src/com/cloud/projects/ProjectService.java dc882ef
api/src/org/apache/cloudstack/api/command/user/account/AddAccountToProjectCmd.java
36df579
api/src/org/apache/cloudstack/api/command/user/account/DeleteAccountFromProjectCmd.java
f6aa36c
api/src/org/apache/cloudstack/api/command/user/project/UpdateProjectInvitationCmd.java
dda7b54
server/src/com/cloud/projects/ProjectManager.java f568146
server/src/com/cloud/projects/ProjectManagerImpl.java 5a0ed1c
server/test/com/cloud/projects/MockProjectManagerImpl.java dc377ff
Diff: https://reviews.apache.org/r/17591/diff/
Testing
-------
Testing done on master.
Thanks,
David Grizzanti