H Alena, You are right. I was under the impression that response format was being extended.
I saw you already reverted. If the response was extended with the extra value it would be alright, would it? On Mon, Mar 3, 2014 at 7:06 PM, Alena Prokharchyk <alena.prokharc...@citrix.com> wrote: > Daan, this fix break API compatibility! All the customers using these API, > will end up with broken code on their side. As the response format is > changed. Can you please roll it back? > > Thanks, > Alena. > > On 3/3/14, 2:03 AM, "daan Hoogland" <daan.hoogl...@gmail.com> wrote: > >> >>----------------------------------------------------------- >>This is an automatically generated e-mail. To reply, visit: >>https://reviews.apache.org/r/17591/#review35953 >>----------------------------------------------------------- >> >>Ship it! >> >> >>ebcaec8632dbd92c071317f3190915244a287afb >> >>- daan Hoogland >> >> >>On Jan. 31, 2014, 2:51 p.m., David Grizzanti wrote: >>> >>> ----------------------------------------------------------- >>> This is an automatically generated e-mail. To reply, visit: >>> https://reviews.apache.org/r/17591/ >>> ----------------------------------------------------------- >>> >>> (Updated Jan. 31, 2014, 2:51 p.m.) >>> >>> >>> Review request for cloudstack. >>> >>> >>> Bugs: CLOUDSTACK-5872 >>> https://issues.apache.org/jira/browse/CLOUDSTACK-5872 >>> >>> >>> Repository: cloudstack-git >>> >>> >>> Description >>> ------- >>> >>> CLOUDSTACK-5872: Async response from addAccountToProject doesn't >>>contain useful information >>> >>> Updated the following classes to return a project object after async >>>jobs complete: >>> api/src/com/cloud/projects/ProjectService.java | 6 ++-- >>> .../user/account/AddAccountToProjectCmd.java | 7 +++-- >>> .../user/account/DeleteAccountFromProjectCmd.java | 7 +++-- >>> .../user/project/UpdateProjectInvitationCmd.java | 8 +++-- >>> server/src/com/cloud/projects/ProjectManager.java | 2 +- >>> .../src/com/cloud/projects/ProjectManagerImpl.java | 34 >>>+++++++++++----------- >>> .../com/cloud/projects/MockProjectManagerImpl.java | 16 +++++----- >>> >>> Previously these API commands only returned "success => true" in the >>>aysnc job result. Now it returns the project that a user was >>>added/deleted to. >>> >>> >>> Diffs >>> ----- >>> >>> api/src/com/cloud/projects/ProjectService.java dc882ef >>> >>>api/src/org/apache/cloudstack/api/command/user/account/AddAccountToProjec >>>tCmd.java 36df579 >>> >>>api/src/org/apache/cloudstack/api/command/user/account/DeleteAccountFromP >>>rojectCmd.java f6aa36c >>> >>>api/src/org/apache/cloudstack/api/command/user/project/UpdateProjectInvit >>>ationCmd.java dda7b54 >>> server/src/com/cloud/projects/ProjectManager.java f568146 >>> server/src/com/cloud/projects/ProjectManagerImpl.java 5a0ed1c >>> server/test/com/cloud/projects/MockProjectManagerImpl.java dc377ff >>> >>> Diff: https://reviews.apache.org/r/17591/diff/ >>> >>> >>> Testing >>> ------- >>> >>> Testing done on master. >>> >>> >>> Thanks, >>> >>> David Grizzanti >>> >>> >> > -- Daan
