----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/18115/#review34484 -----------------------------------------------------------
Ship it! commit 41721391cf296ce327ff3cce735fc7e018721c9e Author: Ian Southam <isout...@schubergphilis.com> Date: Mon Feb 10 16:04:48 2014 +0100 Findbugs finding Signed-off-by: Hugo Trippaers <htrippa...@schubergphilis.com> - Hugo Trippaers On Feb. 14, 2014, 12:03 p.m., Ian Southam wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/18115/ > ----------------------------------------------------------- > > (Updated Feb. 14, 2014, 12:03 p.m.) > > > Review request for cloudstack, daan Hoogland and Hugo Trippaers. > > > Repository: cloudstack-git > > > Description > ------- > > Part of a small project te eliminate bugs from cloudstack. > Includes a basic unit test > > > Diffs > ----- > > > services/console-proxy/server/src/com/cloud/consoleproxy/ConsoleProxyRdpClient.java > 7d49b19 > > services/console-proxy/server/test/com/cloud/consoleproxy/ConsoleProxyRdpClientTest.java > PRE-CREATION > > Diff: https://reviews.apache.org/r/18115/diff/ > > > Testing > ------- > > > Thanks, > > Ian Southam > >