-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/18116/#review34492
-----------------------------------------------------------
Ship it!
commit de24d7615099b4a61c65051f505608f9d0ad26db
Author: Antonio Fornie <afor...@schubergphilis.com>
Date: Tue Feb 11 15:10:23 2014 +0100
Fix and test GroupBy SQL query creation
Signed-off-by: Ian Southam <isout...@schubergphilis.com>
Signed-off-by: Hugo Trippaers <htrippa...@schubergphilis.com>
- Hugo Trippaers
On Feb. 14, 2014, 2:10 p.m., Ian Southam wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/18116/
> -----------------------------------------------------------
>
> (Updated Feb. 14, 2014, 2:10 p.m.)
>
>
> Review request for cloudstack, daan Hoogland and Hugo Trippaers.
>
>
> Repository: cloudstack-git
>
>
> Description
> -------
>
> Findbugs finding fixed.
>
> Incorrect String comparison (==)
>
> Uncludes Unit Test (with thanks to Antonio)
>
>
> Diffs
> -----
>
> framework/db/src/com/cloud/utils/db/GroupBy.java 716b585
> framework/db/src/com/cloud/utils/db/SearchBase.java 3f123be
> framework/db/test/com/cloud/utils/db/GroupByTest.java PRE-CREATION
>
> Diff: https://reviews.apache.org/r/18116/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Ian Southam
>
>
