Fixed. Applied and mvn build works completely
2014-03-04 0:37 GMT+01:00 Alena Prokharchyk <alena.prokharc...@citrix.com>: > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/17888/ > > Getting compilation error after applying the latest: > > [ERROR] Failed to execute goal > org.apache.maven.plugins:maven-compiler-plugin:2.5.1:compile > (default-compile) on project cloud-server: Compilation failure > [ERROR] > /Users/alena/repos/dr/cloudstack/server/src/com/cloud/network/router/VirtualNetworkApplianceManagerImpl.java:[4202,33] > error: cannot find symbol > [ERROR] -> [Help 1] > > > - Alena Prokharchyk > > On March 3rd, 2014, 11:26 p.m. UTC, Antonio Fornie wrote: > Review request for cloudstack, Alena Prokharchyk, daan Hoogland, and > Hugo Trippaers. > By Antonio Fornie. > > *Updated March 3, 2014, 11:26 p.m.* > *Repository: * cloudstack-git > Description > > Dispatcher corrections, refactoring and tests. Corrects problems from > previous attempts that were reverted by Alena. Most of the changes are the > same, but this one is not creating conflicts of Map types for Aync Commands > or for parameters as Lists or Maps. > > Testing > > Full build and test plus manually testing many features. Also including > CreateTagsCommand that failed in previous commit. > > All unit and integration tests. > > Test CS Web UI with the browser going through several use cases. > > Also use the CS API by sending HTTP requests generated manually including > requests for Async Commands with Map parameters and during these tests apart > fromtesting correct functionality I also debugged to check that Maps created > correctly where they should but also that in the cases where the async > command must be persisted and later on retrieved and deserialized by gson > everything works ok and does what and where is expected. An example based on > the comment by > Alena:http://localhost:8096/client/api?command=createTags&resourceids=ids&resourcetype=type&tags[0].key=region&tags[0].value=canada > Also other examples > likehttp://localhost:8096/client/api?command=createSecondaryStagingStore&url=httpbla&details[0].key=region&details[0].value=canada&details[1].key=element&details[1].value=fire > > Diffs > > - api/src/org/apache/cloudstack/api/ApiConstants.java (7b7f9ca) > - api/src/org/apache/cloudstack/api/BaseCmd.java (0e83cee) > - api/src/org/apache/cloudstack/api/BaseListCmd.java (c1a4b4c) > - api/src/org/apache/cloudstack/api/command/admin/user/GetUserCmd.java > (b2c6734) > - api/src/org/apache/cloudstack/api/command/admin/user/UpdateUserCmd.java > (cf5d355) > - > api/src/org/apache/cloudstack/api/command/user/autoscale/CreateAutoScaleVmProfileCmd.java > (570e018) > - > server/resources/META-INF/cloudstack/core/spring-server-core-misc-context.xml > (fd2f5fb) > - server/src/com/cloud/api/ApiAsyncJobDispatcher.java (f037f2e) > - server/src/com/cloud/api/ApiDispatcher.java (ed95c72) > - server/src/com/cloud/api/ApiServer.java (25792fb) > - server/src/com/cloud/api/ApiServlet.java (46f7eba) > - server/src/com/cloud/api/dispatch/CommandCreationWorker.java > (PRE-CREATION) > - server/src/com/cloud/api/dispatch/DispatchChain.java (PRE-CREATION) > - server/src/com/cloud/api/dispatch/DispatchChainFactory.java > (PRE-CREATION) > - server/src/com/cloud/api/dispatch/DispatchTask.java (PRE-CREATION) > - server/src/com/cloud/api/dispatch/DispatchWorker.java (PRE-CREATION) > - server/src/com/cloud/api/dispatch/ParamGenericValidationWorker.java > (PRE-CREATION) > - server/src/com/cloud/api/dispatch/ParamProcessWorker.java > (PRE-CREATION) > - server/src/com/cloud/api/dispatch/ParamSemanticValidationWorker.java > (PRE-CREATION) > - server/src/com/cloud/api/dispatch/ParamUnpackWorker.java > (PRE-CREATION) > - server/src/com/cloud/network/as/AutoScaleManagerImpl.java (208b4a4) > - server/src/com/cloud/storage/snapshot/SnapshotSchedulerImpl.java > (183a13a) > - server/test/com/cloud/api/ApiDispatcherTest.java (7314a57) > - server/test/com/cloud/api/dispatch/CommandCreationWorkerTest.java > (PRE-CREATION) > - server/test/com/cloud/api/dispatch/DispatchChainFactoryTest.java > (PRE-CREATION) > - server/test/com/cloud/api/dispatch/ParamGenericValidationWorkerTest.java > (PRE-CREATION) > - server/test/com/cloud/api/dispatch/ParamProcessWorkerTest.java > (PRE-CREATION) > - server/test/com/cloud/api/dispatch/ParamSemanticValidationWorkerTest.java > (PRE-CREATION) > > View Diff <https://reviews.apache.org/r/17888/diff/> >
