----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/18677/#review38080 -----------------------------------------------------------
change look good. But patch does not apply on master. Could you please upload proper patch? Also current patch fixes only action events, do you wish to add similar logic for alerts and usage events as well? - Murali Reddy On March 20, 2014, 7:43 a.m., Sonal Ojha wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/18677/ > ----------------------------------------------------------- > > (Updated March 20, 2014, 7:43 a.m.) > > > Review request for cloudstack, Chiradeep Vittal and Murali Reddy. > > > Bugs: CLOUDSTACK-3272 > https://issues.apache.org/jira/browse/CLOUDSTACK-3272 > > > Repository: cloudstack-git > > > Description > ------- > > At present, there are multiple event types that are generated by CS, action > events,usage events, resource state change events and alerts. Current problem > is > all the events gets published on the event bus when event bus is enabled. > Intent is to introduce global setting config parameters to specify which > category of events to be published or not be published on the event bus. > > > Diffs > ----- > > server/src/com/cloud/configuration/Config.java 2d55f46 > server/src/com/cloud/event/ActionEventUtils.java 00122de > server/src/com/cloud/test/DatabaseConfig.java 9370218 > > Diff: https://reviews.apache.org/r/18677/diff/ > > > Testing > ------- > > Successfully tested publishing / not publishing of various events based on > the global parameter publish.*.events. > > > Thanks, > > Sonal Ojha > >
