-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/21156/
-----------------------------------------------------------
Review request for cloudstack, Devdeep Singh and Rajesh Battala.
Bugs: CLOUDSTACK-6575
https://issues.apache.org/jira/browse/CLOUDSTACK-6575
Repository: cloudstack-git
Description
-------
Deploy VM failed with NPE while using custom compute offering:
Steps to reproduce:
1. Install and configure Adv zone.
2. Create Compute offering with Custom option enabled.
3. Deploy VM using Default Cent OS template using Custom option enabled Compute
offering.
Root Cause:
In schema-410to420.sql ALTER TABLE `cloud`.`disk_offering` ADD COLUMN
`customized_iops` tinyint(1) unsigned COMMENT 'Should customized IOPS be
displayed to the end user';
The default value of customized_iops is null and ServiceOfferingVO construtor
calls the super constructor in DiskOfferingVO passing null to boolean value,
hence the NPE.
Fix: Change Boolean to boolean with appropriate conversions.
Diffs
-----
engine/schema/src/com/cloud/service/ServiceOfferingVO.java 3be0aaa
Diff: https://reviews.apache.org/r/21156/diff/
Testing
-------
Deployed vm with customized_iops as null in disk_offering table.
Deployed vm with customized_iops as not null in disk_offering table.
Both the deployments pass.
Build passes successfully.
Thanks,
Saksham Srivastava
