> On June 12, 2014, 3:27 p.m., Santhosh Edukulla wrote: > > test/integration/smoke/test_deploy_vgpu_enabled_vm.py, line 126 > > <https://reviews.apache.org/r/22512/diff/1/?file=608112#file608112line126> > > > > If this is specific to entire module, then its better we move this > > check to setup class instead and skip.
Which module are you referring to - there isn't a specific vGPU module in Marvin as far as I can see, the test just creates a ServiceOffering for VGPU with 'pciDevice': 'VGPU' set? > On June 12, 2014, 3:27 p.m., Santhosh Edukulla wrote: > > test/integration/smoke/test_deploy_vgpu_enabled_vm.py, line 164 > > <https://reviews.apache.org/r/22512/diff/1/?file=608112#file608112line164> > > > > Dont we require other advanced, basic,provisioning tags? Otherwise it > > may run on non required setups as well. As I understand it (which is quite liable to be wrong) the tags are OR'd together, there's no way of specifying that a specific attribute *must* be provided for the test to run. Only options here therefore are: 1. Ensure the BVTs (and any other run of Marvin tests that's not on VGPU hardware) have a !vgpu tag specified 2. Have a separate set of vgpu-advanced, vgpu-basic etc tags - Alex ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/22512/#review45503 ----------------------------------------------------------- On June 12, 2014, 1:27 p.m., Alex Brett wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/22512/ > ----------------------------------------------------------- > > (Updated June 12, 2014, 1:27 p.m.) > > > Review request for cloudstack and SrikanteswaraRao Talluri. > > > Bugs: CLOUDSTACK-6862 and CLOUDSTACK-6876 > https://issues.apache.org/jira/browse/CLOUDSTACK-6862 > https://issues.apache.org/jira/browse/CLOUDSTACK-6876 > > > Repository: cloudstack-git > > > Description > ------- > > - Make this test skip if it's not running on a XenServer host (as that's the > only hypervisor that supports vGPU at present) > - Also remove the tags that make this test run on a BVT, since it will *only* > work if run on a host with vGPU hardware > > See also CLOUDSTACK-6876 - I don't have rights to duplicate these two issues, > but I believe they are the same thing. > > > Diffs > ----- > > test/integration/smoke/test_deploy_vgpu_enabled_vm.py fa33bdc > > Diff: https://reviews.apache.org/r/22512/diff/ > > > Testing > ------- > > Tested against a KVM host to ensure the skip logic kicks in. > > > Thanks, > > Alex Brett > >
