-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/23735/
-----------------------------------------------------------

Review request for cloudstack, daan Hoogland, John Dilley, Santhosh Edukulla, 
and Hugo Trippaers.


Repository: cloudstack-git


Description
-------

The DevCloud wiki page [1] instructs developers to deploy a DC with basic 
networking with the following command:
$ python tools/marvin/marvin/deployDataCenter.py -i 
tools/devcloud/devcloud-advanced.cfg


However, that produces the error message bellow:

        Exception Occurred Under createLogs :['Traceback (most recent call 
last):\n', '  File 
"/Users/mferreira/development/git/cloudstack-sbp/tools/marvin/marvin/marvinLog.py",
 line 157, in createLogs\n    (\'LogFolderPath\' in log_cfg.__dict__.keys()) 
and\n', "AttributeError: 'list' object has no attribute '__dict__'\n"]

        ===Log Creation Failed. Please Check===


The cause of the error is the unexpected format of the logger element in 
tools/devcloud/devcloud-advanced.cfg
The patch I'm submitting add support for lists in the logger element of the 
configuration.

In addition the patch also provides small fixes for the deployment 
configuration of basic and advanced zones.


[1] - https://cwiki.apache.org/confluence/display/CLOUDSTACK/DevCloud


Diffs
-----

  tools/devcloud/devcloud-advanced.cfg 74b6366 
  tools/devcloud/devcloud.cfg 5232e3a 
  tools/marvin/marvin/deployDataCenter.py ae48839 
  tools/marvin/marvin/marvinLog.py ea8eaee 

Diff: https://reviews.apache.org/r/23735/diff/


Testing
-------

With the patch I was able to deploy a zone in cloudstack.


Thanks,

Miguel Ferreira

Reply via email to