> On Aug. 18, 2014, 5:36 a.m., sanjeev n wrote: > > test/integration/component/test_dedicate_guest_vlan_ranges.py, line 1197 > > <https://reviews.apache.org/r/24055/diff/1/?file=644474#file644474line1197> > > > > This assert statement does not make sense because no vlan would be > > assigned to the network created here. Not sure what would be the value of > > netowrks[0].vlan when there is no vlan assigned for the network. > > Ashutosh Kelkar wrote: > Why would there be no vlan assigned? The network takes vlan from the > dedicated range automatically, and if dedicated range is not availble, then > it will take random vlan from the vlan range of physical network.
I have used persistent network here, hence it will automatically get a vlan id even when VM is not deployed in it. - Ashutosh ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/24055/#review50850 ----------------------------------------------------------- On Aug. 22, 2014, 10:14 a.m., Ashutosh Kelkar wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/24055/ > ----------------------------------------------------------- > > (Updated Aug. 22, 2014, 10:14 a.m.) > > > Review request for cloudstack, suresh sadhu, sailaja mada, sanjeev n, and > Sowmya Krishnan. > > > Bugs: CLOUDSTACK-2251 > https://issues.apache.org/jira/browse/CLOUDSTACK-2251 > > > Repository: cloudstack-git > > > Description > ------- > > Automation test cases for feature - Dedicated guest VLAN ranges per tenant > > > Diffs > ----- > > test/integration/component/test_dedicate_guest_vlan_ranges.py PRE-CREATION > tools/marvin/marvin/lib/base.py f0d53a6 > tools/marvin/marvin/lib/common.py 3706456 > > Diff: https://reviews.apache.org/r/24055/diff/ > > > Testing > ------- > > Yes. > > > Thanks, > > Ashutosh Kelkar > >
