> On Aug. 18, 2014, 5:36 a.m., sanjeev n wrote: > > test/integration/component/test_dedicate_guest_vlan_ranges.py, line 1197 > > <https://reviews.apache.org/r/24055/diff/1/?file=644474#file644474line1197> > > > > This assert statement does not make sense because no vlan would be > > assigned to the network created here. Not sure what would be the value of > > netowrks[0].vlan when there is no vlan assigned for the network.
Why would there be no vlan assigned? The network takes vlan from the dedicated range automatically, and if dedicated range is not availble, then it will take random vlan from the vlan range of physical network. > On Aug. 18, 2014, 5:36 a.m., sanjeev n wrote: > > test/integration/component/test_dedicate_guest_vlan_ranges.py, line 1201 > > <https://reviews.apache.org/r/24055/diff/1/?file=644474#file644474line1201> > > > > Not catching the exception if releasing vlan range fails for some > > reason. Add code to handle the error in releasing vlan range. I don't think that is necessary, because anyway cleanup operation will be called when exception occurs in the test case. And if releasing vlan range fails then there is nothing to do explicitly. We will get to see the reason in the logs. > On Aug. 18, 2014, 5:36 a.m., sanjeev n wrote: > > test/integration/component/test_dedicate_guest_vlan_ranges.py, line 567 > > <https://reviews.apache.org/r/24055/diff/1/?file=644474#file644474line567> > > > > Add assertions to check whether the vlan dedecation is success or not. > > Applies to account2 as well. Will do. > On Aug. 18, 2014, 5:36 a.m., sanjeev n wrote: > > test/integration/component/test_dedicate_guest_vlan_ranges.py, line 962 > > <https://reviews.apache.org/r/24055/diff/1/?file=644474#file644474line962> > > > > Add assertion since this is where the actual test is happening. Will do. - Ashutosh ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/24055/#review50850 ----------------------------------------------------------- On July 29, 2014, 2:20 p.m., Ashutosh Kelkar wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/24055/ > ----------------------------------------------------------- > > (Updated July 29, 2014, 2:20 p.m.) > > > Review request for cloudstack, suresh sadhu, sailaja mada, sanjeev n, and > Sowmya Krishnan. > > > Bugs: CLOUDSTACK-2251 > https://issues.apache.org/jira/browse/CLOUDSTACK-2251 > > > Repository: cloudstack-git > > > Description > ------- > > Automation test cases for feature - Dedicated guest VLAN ranges per tenant > > > Diffs > ----- > > test/integration/component/test_dedicate_guest_vlan_ranges.py PRE-CREATION > tools/marvin/marvin/lib/base.py 58033c6 > tools/marvin/marvin/lib/common.py 187ede6 > > Diff: https://reviews.apache.org/r/24055/diff/ > > > Testing > ------- > > Yes. > > > Thanks, > > Ashutosh Kelkar > >
