> On Sept. 1, 2014, 8:08 a.m., Hugo Trippaers wrote: > > KC, > > > > Thanks for submitting this review, looking forward to seeing the updated > > version of the bigswitch plugin in CloudStack. > > > > You replace all the existing VNS code with BCF code, is there a need to > > deal with users that want to upgrade from VNS to the new system? > > > > As part of our focus on more and better testing, could you include a > > functional test that we could use to verify correct behaviour of the > > plugin? It is OK if it only works if you hve the hardware/software > > available but we ned some way to integrate that test in our CI systems. > > Have a look at the test/integration/ directory in the CloudStack source for > > some ideas. > > > > Could you add the following to the pom.xml? This will help us verify > > license issues. > > <plugins> > > <plugin> > > <groupId>com.mycila</groupId> > > <artifactId>license-maven-plugin</artifactId> > > <executions> > > <execution> > > <id>cloudstack-checklicence</id> > > <phase>process-classes</phase> > > <goals> > > <goal>check</goal> > > </goals> > > </execution> > > </executions> > > </plugin> > > > > As part of the review i'll be running both findbugs and PMD checks as well. > > I'll update the review if i find any issues there. > > > > Cheers, > > > > Hugo
Hugo - thanks to your review, I am posting a new patch that: 1) added license-maven-plugin, 2) added pmd plugin, 3) added marvin test that passed successfully with our controller in our test setup, 4) bug fixes caught by running marvin test, 5) added hook to enable plugin in VPC workflow as well, 6) code refactoring for better code reuse - Kuang-Ching ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/24991/#review51976 ----------------------------------------------------------- On Sept. 26, 2014, 10:12 p.m., Kuang-Ching Wang wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/24991/ > ----------------------------------------------------------- > > (Updated Sept. 26, 2014, 10:12 p.m.) > > > Review request for cloudstack, Chiradeep Vittal, David Nalley, Sebastien > Goasguen, and Hugo Trippaers. > > > Repository: cloudstack-git > > > Description > ------- > > CLOUDSTACK-6697: BigSwitchVns plugin update > > This patch updates the BigSwitch network plugin in the following ways: > - provides compatibility with Big Switch's Big Cloud Fabric controller > - provides L2 Connectivity service > - uses HTTPS with sticky/trust-always certificate handling > - Updates plugin terminology in package name, code, and GUI to BigSwitchBCF > with isolation method referred to as "BCF_SEGMENT" > > > Diffs > ----- > > api/src/com/cloud/network/Network.java > c5a9bf286df8d502a6ca33661fb52ee717643566 > api/src/com/cloud/network/PhysicalNetwork.java > 7c9349d932771fdbecc4a0b1ae4cad28b3d67857 > client/WEB-INF/classes/resources/messages.properties > c9eb7ae24666ca8f3dbd5914539af827489313b6 > client/WEB-INF/classes/resources/messages_fr_FR.properties > 004187f69b4f8449c88214ff3b047ef603ad65dc > client/WEB-INF/classes/resources/messages_ja_JP.properties > 7bc90b538a4f8160e74b72720bc83a776d244b75 > client/WEB-INF/classes/resources/messages_ko_KR.properties > ce79d2e5b27d861960c8ee1fd4b1e099ed883ef3 > client/WEB-INF/classes/resources/messages_nl_NL.properties > 89ef828a3c157228680b90adbcb76b182f342638 > client/WEB-INF/classes/resources/messages_pt_BR.properties > 8ee08ba3cbbfa3285b7ad728b8b119ee9e379c65 > client/WEB-INF/classes/resources/messages_ru_RU.properties > ff68668e6ff75546236a11d29e37d8d4ad1f58f1 > client/WEB-INF/classes/resources/messages_zh_CN.properties > ebba5e0bb07a992ee55eb2ab8e71a11073064cfe > client/pom.xml dccf18d2d4dec0390c487ca87f4cf116f5deb8f7 > client/tomcatconf/commands.properties.in > 09b7ddc8ee9e9dd85a72f81b373bc69a0ec91942 > engine/schema/src/com/cloud/user/dao/VmDiskStatisticsDaoImpl.java > e1136d3cf567b73fd1198181aea4d6995df6b78a > plugins/network-elements/bigswitch-vns/pom.xml > 6665454e4190f1d10fe91dfa62828e456758d0d8 > > plugins/network-elements/bigswitch-vns/resources/META-INF/cloudstack/vns/module.properties > 5783d38e5cb78be0d418c80981246d721d18b62a > > plugins/network-elements/bigswitch-vns/resources/META-INF/cloudstack/vns/spring-vns-context.xml > d5bb92afe3d3051dbdd4b4d49698c313c77d255f > > plugins/network-elements/bigswitch-vns/src/com/cloud/agent/api/CreateVnsNetworkAnswer.java > e950abe3bed85b75a20be2b8c4537a2fbd6be39e > > plugins/network-elements/bigswitch-vns/src/com/cloud/agent/api/CreateVnsNetworkCommand.java > 534bb7f9f9154a652a20310fe020bddc4249ef54 > > plugins/network-elements/bigswitch-vns/src/com/cloud/agent/api/CreateVnsPortAnswer.java > 82c2fe90d63e0148bca8de9ce8612e4dd53cf735 > > plugins/network-elements/bigswitch-vns/src/com/cloud/agent/api/CreateVnsPortCommand.java > c3b9a9d6d9504e34cbe1294ac640f56aab101395 > > plugins/network-elements/bigswitch-vns/src/com/cloud/agent/api/DeleteVnsNetworkAnswer.java > 72ac98ac9e0a1ae4858019e3baccc160300e24bf > > plugins/network-elements/bigswitch-vns/src/com/cloud/agent/api/DeleteVnsNetworkCommand.java > 6cf169bbfc97b57561af729aef297c76230fd118 > > plugins/network-elements/bigswitch-vns/src/com/cloud/agent/api/DeleteVnsPortAnswer.java > 076b187fdf48cf776902dc9a91dc26e00396158a > > plugins/network-elements/bigswitch-vns/src/com/cloud/agent/api/DeleteVnsPortCommand.java > 0cae01d471dd9c5c504002c24f865ded59812d9e > > plugins/network-elements/bigswitch-vns/src/com/cloud/agent/api/StartupBigSwitchVnsCommand.java > 8310b0763708c3f049ef4ce427d09f0c07cd05b3 > > plugins/network-elements/bigswitch-vns/src/com/cloud/agent/api/UpdateVnsPortAnswer.java > 39cd26649c9bb0c4993f55bef65edfc326c4ceda > > plugins/network-elements/bigswitch-vns/src/com/cloud/agent/api/UpdateVnsPortCommand.java > 40f09207606115a5d0ec7f9378c4c52d16405dfd > > plugins/network-elements/bigswitch-vns/src/com/cloud/api/commands/AddBigSwitchVnsDeviceCmd.java > 5c6f555c8a40a4b785aed6fdfa743131006be209 > > plugins/network-elements/bigswitch-vns/src/com/cloud/api/commands/DeleteBigSwitchVnsDeviceCmd.java > 1e2155dcd899bc11f9e9463cec432c020751e905 > > plugins/network-elements/bigswitch-vns/src/com/cloud/api/commands/ListBigSwitchVnsDevicesCmd.java > 4cde78e503935f7ba3b4a90a6f4568f0dd32c7ab > > plugins/network-elements/bigswitch-vns/src/com/cloud/api/commands/VnsConstants.java > 7942b6f2be3467465334b0628577b87564dbdab2 > > plugins/network-elements/bigswitch-vns/src/com/cloud/api/response/BigSwitchVnsDeviceResponse.java > 790ac9c6afbee9156cb8d26ee2a2b5980fe4ce18 > > plugins/network-elements/bigswitch-vns/src/com/cloud/network/BigSwitchVnsDeviceVO.java > 01b5d49a90bb4428716d6b9c344d4ccfc97fb34f > > plugins/network-elements/bigswitch-vns/src/com/cloud/network/bigswitch/AttachmentData.java > f1866e2621b6f9c19e4a9be310791b086ce3a350 > > plugins/network-elements/bigswitch-vns/src/com/cloud/network/bigswitch/BigSwitchVnsApi.java > 44445992858317e8e27ba45c13bd01ce1fbdef28 > > plugins/network-elements/bigswitch-vns/src/com/cloud/network/bigswitch/BigSwitchVnsApiException.java > d03dc7c7d5b528402a2271c785507f6dbaef2705 > > plugins/network-elements/bigswitch-vns/src/com/cloud/network/bigswitch/ControlClusterStatus.java > 78ac02399d19818dcf37adcca5e13990a18ea44c > > plugins/network-elements/bigswitch-vns/src/com/cloud/network/bigswitch/NetworkData.java > e44c0f4f7dfb65ba89551d0a5afe50df40e61fbb > > plugins/network-elements/bigswitch-vns/src/com/cloud/network/bigswitch/PortData.java > d228d37caaceaf58232a41ac71a3d92ed6071b1b > > plugins/network-elements/bigswitch-vns/src/com/cloud/network/dao/BigSwitchVnsDao.java > da4e0035ebc041005b7379ece0407039bec13bbe > > plugins/network-elements/bigswitch-vns/src/com/cloud/network/dao/BigSwitchVnsDaoImpl.java > 0779ea2ae4edba02c6f0d4b009a3dbe4c39d98c9 > > plugins/network-elements/bigswitch-vns/src/com/cloud/network/element/BigSwitchVnsElement.java > c2b603221b34a5f71c6d1baafedcc7bd3810d11c > > plugins/network-elements/bigswitch-vns/src/com/cloud/network/element/BigSwitchVnsElementService.java > edcf6a148c3c6a052eb1a4e4caa7482c329584d4 > > plugins/network-elements/bigswitch-vns/src/com/cloud/network/guru/BigSwitchVnsGuestNetworkGuru.java > 9805144ef92b06e3bcfaa4d31b74141d8f5e0266 > > plugins/network-elements/bigswitch-vns/src/com/cloud/network/resource/BigSwitchVnsResource.java > 223972e2edcdc5fba114b13f7decd6c1704aaf46 > > plugins/network-elements/bigswitch-vns/test/com/cloud/network/bigswitch/BigSwitchApiTest.java > 4d8021c5f77c910db36904fdb39d3934b657ed03 > > plugins/network-elements/bigswitch-vns/test/com/cloud/network/resource/BigSwitchVnsResourceTest.java > 8cf322ad19f8f8ad795edf18e4c939a6f88852ad > plugins/network-elements/bigswitch/findbugsExcludeFilter.xml PRE-CREATION > plugins/network-elements/bigswitch/pom.xml PRE-CREATION > > plugins/network-elements/bigswitch/resources/META-INF/cloudstack/bigswitch/module.properties > PRE-CREATION > > plugins/network-elements/bigswitch/resources/META-INF/cloudstack/bigswitch/spring-bigswitch-context.xml > PRE-CREATION > > plugins/network-elements/bigswitch/src/com/cloud/agent/api/CreateBcfAttachmentAnswer.java > PRE-CREATION > > plugins/network-elements/bigswitch/src/com/cloud/agent/api/CreateBcfAttachmentCommand.java > PRE-CREATION > > plugins/network-elements/bigswitch/src/com/cloud/agent/api/CreateBcfSegmentAnswer.java > PRE-CREATION > > plugins/network-elements/bigswitch/src/com/cloud/agent/api/CreateBcfSegmentCommand.java > PRE-CREATION > > plugins/network-elements/bigswitch/src/com/cloud/agent/api/DeleteBcfAttachmentAnswer.java > PRE-CREATION > > plugins/network-elements/bigswitch/src/com/cloud/agent/api/DeleteBcfAttachmentCommand.java > PRE-CREATION > > plugins/network-elements/bigswitch/src/com/cloud/agent/api/DeleteBcfSegmentAnswer.java > PRE-CREATION > > plugins/network-elements/bigswitch/src/com/cloud/agent/api/DeleteBcfSegmentCommand.java > PRE-CREATION > > plugins/network-elements/bigswitch/src/com/cloud/agent/api/StartupBigSwitchBcfCommand.java > PRE-CREATION > > plugins/network-elements/bigswitch/src/com/cloud/agent/api/UpdateBcfAttachmentAnswer.java > PRE-CREATION > > plugins/network-elements/bigswitch/src/com/cloud/agent/api/UpdateBcfAttachmentCommand.java > PRE-CREATION > > plugins/network-elements/bigswitch/src/com/cloud/api/commands/AddBigSwitchBcfDeviceCmd.java > PRE-CREATION > > plugins/network-elements/bigswitch/src/com/cloud/api/commands/BcfConstants.java > PRE-CREATION > > plugins/network-elements/bigswitch/src/com/cloud/api/commands/DeleteBigSwitchBcfDeviceCmd.java > PRE-CREATION > > plugins/network-elements/bigswitch/src/com/cloud/api/commands/ListBigSwitchBcfDevicesCmd.java > PRE-CREATION > > plugins/network-elements/bigswitch/src/com/cloud/api/response/BigSwitchBcfDeviceResponse.java > PRE-CREATION > > plugins/network-elements/bigswitch/src/com/cloud/network/BigSwitchBcfDeviceVO.java > PRE-CREATION > > plugins/network-elements/bigswitch/src/com/cloud/network/bigswitch/AttachmentData.java > PRE-CREATION > > plugins/network-elements/bigswitch/src/com/cloud/network/bigswitch/BigSwitchBcfApi.java > PRE-CREATION > > plugins/network-elements/bigswitch/src/com/cloud/network/bigswitch/BigSwitchBcfApiException.java > PRE-CREATION > > plugins/network-elements/bigswitch/src/com/cloud/network/bigswitch/Capabilities.java > PRE-CREATION > > plugins/network-elements/bigswitch/src/com/cloud/network/bigswitch/ControlClusterStatus.java > PRE-CREATION > > plugins/network-elements/bigswitch/src/com/cloud/network/bigswitch/NetworkData.java > PRE-CREATION > > plugins/network-elements/bigswitch/src/com/cloud/network/bigswitch/TrustingProtocolSocketFactory.java > PRE-CREATION > > plugins/network-elements/bigswitch/src/com/cloud/network/dao/BigSwitchBcfDao.java > PRE-CREATION > > plugins/network-elements/bigswitch/src/com/cloud/network/dao/BigSwitchBcfDaoImpl.java > PRE-CREATION > > plugins/network-elements/bigswitch/src/com/cloud/network/element/BigSwitchBcfElement.java > PRE-CREATION > > plugins/network-elements/bigswitch/src/com/cloud/network/element/BigSwitchBcfElementService.java > PRE-CREATION > > plugins/network-elements/bigswitch/src/com/cloud/network/guru/BigSwitchBcfGuestNetworkGuru.java > PRE-CREATION > > plugins/network-elements/bigswitch/src/com/cloud/network/resource/BigSwitchBcfResource.java > PRE-CREATION > > plugins/network-elements/bigswitch/test/com/cloud/network/bigswitch/BigSwitchApiTest.java > PRE-CREATION > > plugins/network-elements/bigswitch/test/com/cloud/network/resource/BigSwitchBcfResourceTest.java > PRE-CREATION > plugins/pom.xml 9e4f35ac4e9582a35dbc47340c25ae678efac6f5 > scripts/installer/windows/client.wxs > 6cca15d3e00850b9dee2e524372198cf577667a5 > server/src/com/cloud/network/vpc/VpcManagerImpl.java > c49da15d024f3cffe6fbfdc957957254a63b259d > setup/db/db/schema-307to410.sql 7feb53eb16e5ed320dab38e919d5f9386127df8c > setup/db/db/schema-40to410.sql 53b4a1a5b8a77e5c537176cf59058314415db43f > test/integration/component/test_bigswitch_bcf.py PRE-CREATION > tools/apidoc/gen_toc.py 95f06c8c1aa685c3b07967221e46daac0d34205c > tools/eclipse/eclipse.epf d7795aac4cf086f34169857b3048409a54932bb6 > ui/dictionary.jsp c03ad67a9e0acbfb34a19257fb80071f638d8b1b > ui/dictionary2.jsp 39299b3dacc2944953396c26e41988db8ede1a9c > ui/scripts/configuration.js b6c94f8337605a763dfc8edce3dd8cd47ec889df > ui/scripts/system.js 3f6efceda4b4da9fdc7e0f88a553c568504be4aa > ui/scripts/ui-custom/zoneWizard.js 2c17f604ba9092e6f81841873337e1fcebf99470 > > Diff: https://reviews.apache.org/r/24991/diff/ > > > Testing > ------- > > Passing unit tests > Cleared Findbugs check > Integration test for network and VM creation (requires BCF controller) > > > Thanks, > > Kuang-Ching Wang > >
