----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/24991/#review63543 -----------------------------------------------------------
Hey KC, I had some trouble applying the latest patch too, it appears a couple of other commits got into your patch as well. I've applied the patch as i think it should be, but could you check the cloudstack branch reviews/24991 to see if everything is in order? Cheers, Hugo - Hugo Trippaers On Nov. 30, 2014, 2:49 a.m., Kuang-Ching Wang wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/24991/ > ----------------------------------------------------------- > > (Updated Nov. 30, 2014, 2:49 a.m.) > > > Review request for cloudstack, Chiradeep Vittal, David Nalley, Sebastien > Goasguen, and Hugo Trippaers. > > > Repository: cloudstack-git > > > Description > ------- > > CLOUDSTACK-6697: Big Switch network plugin update > 1. provide compatibility with the Big Cloud Fabric (BCF) controller > L2 Connectivity Service in both VPC and non-VPC modes > 2. virtual network terminology updates: VNS --> BCF_SEGMENT > 3. uses HTTPS with trust-always certificate handling > 4. topology sync support with BCF controller > 5. support multiple (two) BCF controllers with HA > 6. support VM migration > > > Diffs > ----- > > .travis.yml cb07a68cb3e7decf7cdb593172d8c9011c418e36 > api/src/com/cloud/network/Network.java > c5a9bf286df8d502a6ca33661fb52ee717643566 > api/src/com/cloud/network/PhysicalNetwork.java > 7c9349d932771fdbecc4a0b1ae4cad28b3d67857 > api/src/org/apache/cloudstack/api/response/UserVmResponse.java > 9fe3475f57afebbd976294e4fd5231cdf77612c2 > client/WEB-INF/classes/resources/messages.properties > 3228578ce81a826f49166a72a6c67143fb12c95d > client/WEB-INF/classes/resources/messages_fr_FR.properties > 54dc6215a8339b9f8c2bad9fe4c3ed18b4a702e7 > client/WEB-INF/classes/resources/messages_ja_JP.properties > 1962e92a4cf47978dae35a3d2b090b4c1765fecb > client/WEB-INF/classes/resources/messages_ko_KR.properties > ced576cb23598e7d3e5005bc24c2adf20b66a826 > client/WEB-INF/classes/resources/messages_nl_NL.properties > 86653a5f5144c75e67b5a6f02c47d37bd5a71ef0 > client/WEB-INF/classes/resources/messages_pt_BR.properties > fa77633a650f1b37d8398a8936bbf84f5b4a40e3 > client/WEB-INF/classes/resources/messages_ru_RU.properties > 7f57daa58bef379ddb47acb88965d0defe32ad73 > client/WEB-INF/classes/resources/messages_zh_CN.properties > 217849582b41cb2c63a0e305e5613af6f659d11d > client/pom.xml 6803f9a11fd2c80523ea16bdd35f2a4d163f953c > client/tomcatconf/commands.properties.in > a87d1677f24657299ec24d4ce9df9a180a62bd0c > engine/schema/src/com/cloud/upgrade/dao/Upgrade442to450.java > dc1057f9033fd783900e6c3b623d3b28fb7d6836 > engine/schema/src/com/cloud/user/dao/VmDiskStatisticsDaoImpl.java > e1136d3cf567b73fd1198181aea4d6995df6b78a > > engine/storage/datamotion/src/org/apache/cloudstack/storage/motion/AncientDataMotionStrategy.java > 5b01f95eef164e725001f34528e46dde0eb15f99 > packaging/centos63/cloud.spec 072a0b94884c5f32176df3ac0083249a52a1f9ed > packaging/centos63/default/macros.spec > f3c937cac37afb39c1d95d223a0debd42c19a505 > packaging/centos63/default/tomcat.sh > 0908da4696e300d0b26a1aef18ce08b1816e9af9 > packaging/centos63/package.sh 00c19478ea0125fbf1ec5902cc7da11d7bbdc5de > packaging/centos63/rhel7/cloud-management.service > 5d69885640416bbf1760eb644a062a1f79b5022a > packaging/centos63/rhel7/macros.spec > 4b7109280abcb22b3f846edd81147391477289e9 > packaging/centos63/rhel7/tomcat.sh 03c6e7b97848a923bf69b57abd2970aeb883c4c7 > packaging/centos63/tomcat.sh PRE-CREATION > packaging/centos7/cloud-agent.rc PRE-CREATION > packaging/centos7/cloud-ipallocator.rc PRE-CREATION > packaging/centos7/cloud-management.service PRE-CREATION > packaging/centos7/cloud-management.sudoers PRE-CREATION > packaging/centos7/cloud-management.sysconfig PRE-CREATION > packaging/centos7/cloud-usage-sysd PRE-CREATION > packaging/centos7/cloud-usage.service PRE-CREATION > packaging/centos7/cloud-usage.sysconfig PRE-CREATION > packaging/centos7/cloud.limits PRE-CREATION > packaging/centos7/cloud.spec PRE-CREATION > packaging/centos7/cloudstack-agent.te PRE-CREATION > packaging/centos7/cloudstack-sccs PRE-CREATION > packaging/centos7/replace.properties PRE-CREATION > packaging/centos7/tomcat7/catalina.properties PRE-CREATION > packaging/centos7/tomcat7/cloud-bridge.properties PRE-CREATION > packaging/centos7/tomcat7/commons-logging.properties PRE-CREATION > packaging/centos7/tomcat7/db.properties PRE-CREATION > packaging/centos7/tomcat7/ec2-service.properties PRE-CREATION > packaging/centos7/tomcat7/environment.properties PRE-CREATION > packaging/centos7/tomcat7/log4j-cloud.xml PRE-CREATION > packaging/centos7/tomcat7/server.xml PRE-CREATION > packaging/centos7/tomcat7/tomcat-users.xml PRE-CREATION > packaging/centos7/tomcat7/web.xml PRE-CREATION > packaging/package.sh PRE-CREATION > > plugins/hypervisors/kvm/src/com/cloud/hypervisor/kvm/resource/LibvirtComputingResource.java > d22487afff1ad8e681aff5303ad0f96af316d8e6 > plugins/network-elements/bigswitch-vns/pom.xml > afb267cdb5bc52aea23bc6739ea21d8f52e94ede > > plugins/network-elements/bigswitch-vns/resources/META-INF/cloudstack/vns/module.properties > 5783d38e5cb78be0d418c80981246d721d18b62a > > plugins/network-elements/bigswitch-vns/resources/META-INF/cloudstack/vns/spring-vns-context.xml > d5bb92afe3d3051dbdd4b4d49698c313c77d255f > > plugins/network-elements/bigswitch-vns/src/com/cloud/agent/api/CreateVnsNetworkAnswer.java > e950abe3bed85b75a20be2b8c4537a2fbd6be39e > > plugins/network-elements/bigswitch-vns/src/com/cloud/agent/api/CreateVnsNetworkCommand.java > 534bb7f9f9154a652a20310fe020bddc4249ef54 > > plugins/network-elements/bigswitch-vns/src/com/cloud/agent/api/CreateVnsPortAnswer.java > 82c2fe90d63e0148bca8de9ce8612e4dd53cf735 > > plugins/network-elements/bigswitch-vns/src/com/cloud/agent/api/CreateVnsPortCommand.java > c3b9a9d6d9504e34cbe1294ac640f56aab101395 > > plugins/network-elements/bigswitch-vns/src/com/cloud/agent/api/DeleteVnsNetworkAnswer.java > 72ac98ac9e0a1ae4858019e3baccc160300e24bf > > plugins/network-elements/bigswitch-vns/src/com/cloud/agent/api/DeleteVnsNetworkCommand.java > 6cf169bbfc97b57561af729aef297c76230fd118 > > plugins/network-elements/bigswitch-vns/src/com/cloud/agent/api/DeleteVnsPortAnswer.java > 076b187fdf48cf776902dc9a91dc26e00396158a > > plugins/network-elements/bigswitch-vns/src/com/cloud/agent/api/DeleteVnsPortCommand.java > 0cae01d471dd9c5c504002c24f865ded59812d9e > > plugins/network-elements/bigswitch-vns/src/com/cloud/agent/api/StartupBigSwitchVnsCommand.java > 8310b0763708c3f049ef4ce427d09f0c07cd05b3 > > plugins/network-elements/bigswitch-vns/src/com/cloud/agent/api/UpdateVnsPortAnswer.java > 39cd26649c9bb0c4993f55bef65edfc326c4ceda > > plugins/network-elements/bigswitch-vns/src/com/cloud/agent/api/UpdateVnsPortCommand.java > 40f09207606115a5d0ec7f9378c4c52d16405dfd > > plugins/network-elements/bigswitch-vns/src/com/cloud/api/commands/AddBigSwitchVnsDeviceCmd.java > 5c6f555c8a40a4b785aed6fdfa743131006be209 > > plugins/network-elements/bigswitch-vns/src/com/cloud/api/commands/DeleteBigSwitchVnsDeviceCmd.java > 1e2155dcd899bc11f9e9463cec432c020751e905 > > plugins/network-elements/bigswitch-vns/src/com/cloud/api/commands/ListBigSwitchVnsDevicesCmd.java > 4cde78e503935f7ba3b4a90a6f4568f0dd32c7ab > > plugins/network-elements/bigswitch-vns/src/com/cloud/api/commands/VnsConstants.java > 7942b6f2be3467465334b0628577b87564dbdab2 > > plugins/network-elements/bigswitch-vns/src/com/cloud/api/response/BigSwitchVnsDeviceResponse.java > 790ac9c6afbee9156cb8d26ee2a2b5980fe4ce18 > > plugins/network-elements/bigswitch-vns/src/com/cloud/network/BigSwitchVnsDeviceVO.java > 01b5d49a90bb4428716d6b9c344d4ccfc97fb34f > > plugins/network-elements/bigswitch-vns/src/com/cloud/network/bigswitch/AttachmentData.java > f1866e2621b6f9c19e4a9be310791b086ce3a350 > > plugins/network-elements/bigswitch-vns/src/com/cloud/network/bigswitch/BigSwitchVnsApi.java > 44445992858317e8e27ba45c13bd01ce1fbdef28 > > plugins/network-elements/bigswitch-vns/src/com/cloud/network/bigswitch/BigSwitchVnsApiException.java > d03dc7c7d5b528402a2271c785507f6dbaef2705 > > plugins/network-elements/bigswitch-vns/src/com/cloud/network/bigswitch/ControlClusterStatus.java > 78ac02399d19818dcf37adcca5e13990a18ea44c > > plugins/network-elements/bigswitch-vns/src/com/cloud/network/bigswitch/NetworkData.java > e44c0f4f7dfb65ba89551d0a5afe50df40e61fbb > > plugins/network-elements/bigswitch-vns/src/com/cloud/network/bigswitch/PortData.java > d228d37caaceaf58232a41ac71a3d92ed6071b1b > > plugins/network-elements/bigswitch-vns/src/com/cloud/network/dao/BigSwitchVnsDao.java > da4e0035ebc041005b7379ece0407039bec13bbe > > plugins/network-elements/bigswitch-vns/src/com/cloud/network/dao/BigSwitchVnsDaoImpl.java > 0779ea2ae4edba02c6f0d4b009a3dbe4c39d98c9 > > plugins/network-elements/bigswitch-vns/src/com/cloud/network/element/BigSwitchVnsElement.java > c2b603221b34a5f71c6d1baafedcc7bd3810d11c > > plugins/network-elements/bigswitch-vns/src/com/cloud/network/element/BigSwitchVnsElementService.java > edcf6a148c3c6a052eb1a4e4caa7482c329584d4 > > plugins/network-elements/bigswitch-vns/src/com/cloud/network/guru/BigSwitchVnsGuestNetworkGuru.java > 9805144ef92b06e3bcfaa4d31b74141d8f5e0266 > > plugins/network-elements/bigswitch-vns/src/com/cloud/network/resource/BigSwitchVnsResource.java > 223972e2edcdc5fba114b13f7decd6c1704aaf46 > > plugins/network-elements/bigswitch-vns/test/com/cloud/network/bigswitch/BigSwitchApiTest.java > 4d8021c5f77c910db36904fdb39d3934b657ed03 > > plugins/network-elements/bigswitch-vns/test/com/cloud/network/resource/BigSwitchVnsResourceTest.java > 8cf322ad19f8f8ad795edf18e4c939a6f88852ad > plugins/network-elements/bigswitch/findbugsExcludeFilter.xml PRE-CREATION > plugins/network-elements/bigswitch/pom.xml PRE-CREATION > > plugins/network-elements/bigswitch/resources/META-INF/cloudstack/bigswitch/module.properties > PRE-CREATION > > plugins/network-elements/bigswitch/resources/META-INF/cloudstack/bigswitch/spring-bigswitch-context.xml > PRE-CREATION > plugins/network-elements/bigswitch/src/com/cloud/agent/api/BcfCommand.java > PRE-CREATION > > plugins/network-elements/bigswitch/src/com/cloud/agent/api/CacheBcfTopologyCommand.java > PRE-CREATION > > plugins/network-elements/bigswitch/src/com/cloud/agent/api/CreateBcfAttachmentAnswer.java > PRE-CREATION > > plugins/network-elements/bigswitch/src/com/cloud/agent/api/CreateBcfAttachmentCommand.java > PRE-CREATION > > plugins/network-elements/bigswitch/src/com/cloud/agent/api/CreateBcfSegmentAnswer.java > PRE-CREATION > > plugins/network-elements/bigswitch/src/com/cloud/agent/api/CreateBcfSegmentCommand.java > PRE-CREATION > > plugins/network-elements/bigswitch/src/com/cloud/agent/api/DeleteBcfAttachmentAnswer.java > PRE-CREATION > > plugins/network-elements/bigswitch/src/com/cloud/agent/api/DeleteBcfAttachmentCommand.java > PRE-CREATION > > plugins/network-elements/bigswitch/src/com/cloud/agent/api/DeleteBcfSegmentAnswer.java > PRE-CREATION > > plugins/network-elements/bigswitch/src/com/cloud/agent/api/DeleteBcfSegmentCommand.java > PRE-CREATION > > plugins/network-elements/bigswitch/src/com/cloud/agent/api/GetControllerDataAnswer.java > PRE-CREATION > > plugins/network-elements/bigswitch/src/com/cloud/agent/api/GetControllerDataCommand.java > PRE-CREATION > > plugins/network-elements/bigswitch/src/com/cloud/agent/api/GetControllerHostsAnswer.java > PRE-CREATION > > plugins/network-elements/bigswitch/src/com/cloud/agent/api/GetControllerHostsCommand.java > PRE-CREATION > > plugins/network-elements/bigswitch/src/com/cloud/agent/api/StartupBigSwitchBcfCommand.java > PRE-CREATION > > plugins/network-elements/bigswitch/src/com/cloud/agent/api/SyncBcfTopologyAnswer.java > PRE-CREATION > > plugins/network-elements/bigswitch/src/com/cloud/agent/api/SyncBcfTopologyCommand.java > PRE-CREATION > > plugins/network-elements/bigswitch/src/com/cloud/agent/api/UpdateBcfAttachmentAnswer.java > PRE-CREATION > > plugins/network-elements/bigswitch/src/com/cloud/agent/api/UpdateBcfAttachmentCommand.java > PRE-CREATION > > plugins/network-elements/bigswitch/src/com/cloud/api/commands/AddBigSwitchBcfDeviceCmd.java > PRE-CREATION > > plugins/network-elements/bigswitch/src/com/cloud/api/commands/BcfConstants.java > PRE-CREATION > > plugins/network-elements/bigswitch/src/com/cloud/api/commands/DeleteBigSwitchBcfDeviceCmd.java > PRE-CREATION > > plugins/network-elements/bigswitch/src/com/cloud/api/commands/ListBigSwitchBcfDevicesCmd.java > PRE-CREATION > > plugins/network-elements/bigswitch/src/com/cloud/api/response/BigSwitchBcfDeviceResponse.java > PRE-CREATION > > plugins/network-elements/bigswitch/src/com/cloud/network/BigSwitchBcfDeviceVO.java > PRE-CREATION > > plugins/network-elements/bigswitch/src/com/cloud/network/bigswitch/AttachmentData.java > PRE-CREATION > > plugins/network-elements/bigswitch/src/com/cloud/network/bigswitch/BigSwitchBcfApi.java > PRE-CREATION > > plugins/network-elements/bigswitch/src/com/cloud/network/bigswitch/BigSwitchBcfApiException.java > PRE-CREATION > > plugins/network-elements/bigswitch/src/com/cloud/network/bigswitch/BigSwitchBcfUtils.java > PRE-CREATION > > plugins/network-elements/bigswitch/src/com/cloud/network/bigswitch/BigSwitchStatus.java > PRE-CREATION > > plugins/network-elements/bigswitch/src/com/cloud/network/bigswitch/Capabilities.java > PRE-CREATION > > plugins/network-elements/bigswitch/src/com/cloud/network/bigswitch/ControlClusterData.java > PRE-CREATION > > plugins/network-elements/bigswitch/src/com/cloud/network/bigswitch/ControlClusterStatus.java > PRE-CREATION > > plugins/network-elements/bigswitch/src/com/cloud/network/bigswitch/ControllerData.java > PRE-CREATION > > plugins/network-elements/bigswitch/src/com/cloud/network/bigswitch/NetworkData.java > PRE-CREATION > > plugins/network-elements/bigswitch/src/com/cloud/network/bigswitch/TopologyData.java > PRE-CREATION > > plugins/network-elements/bigswitch/src/com/cloud/network/bigswitch/TrustingProtocolSocketFactory.java > PRE-CREATION > > plugins/network-elements/bigswitch/src/com/cloud/network/dao/BigSwitchBcfDao.java > PRE-CREATION > > plugins/network-elements/bigswitch/src/com/cloud/network/dao/BigSwitchBcfDaoImpl.java > PRE-CREATION > > plugins/network-elements/bigswitch/src/com/cloud/network/element/BigSwitchBcfElement.java > PRE-CREATION > > plugins/network-elements/bigswitch/src/com/cloud/network/element/BigSwitchBcfElementService.java > PRE-CREATION > > plugins/network-elements/bigswitch/src/com/cloud/network/guru/BigSwitchBcfGuestNetworkGuru.java > PRE-CREATION > > plugins/network-elements/bigswitch/src/com/cloud/network/resource/BigSwitchBcfResource.java > PRE-CREATION > > plugins/network-elements/bigswitch/test/com/cloud/network/bigswitch/BigSwitchApiTest.java > PRE-CREATION > > plugins/network-elements/bigswitch/test/com/cloud/network/resource/BigSwitchBcfResourceTest.java > PRE-CREATION > > plugins/network-elements/internal-loadbalancer/src/org/apache/cloudstack/network/lb/InternalLoadBalancerVMManager.java > 803d3a5d7eb73949eeedf3054d1175078815973c > plugins/pom.xml 76119dc45467067fef91964eccb58d5f4c889ca9 > scripts/installer/windows/client.wxs > 6cca15d3e00850b9dee2e524372198cf577667a5 > server/src/com/cloud/api/ApiDBUtils.java > bd974f941c9d1bc793305bead6694ab274b03cde > server/src/com/cloud/api/ApiServer.java > 435efa0d250418b8d4d2da2f2afd325128f7ad14 > server/src/com/cloud/api/auth/APIAuthenticationManagerImpl.java > fc21b1913e45ea3eb596396e87f1276e2f938338 > server/src/com/cloud/api/query/dao/ResourceTagJoinDao.java > 1524705b6d6c250e46c8a2890a6b20d5541faf83 > server/src/com/cloud/api/query/dao/ResourceTagJoinDaoImpl.java > 27d3787ce0fa44a0964460026ff47209a39b648e > server/src/com/cloud/api/query/dao/UserVmJoinDaoImpl.java > 779ddb4c35faf2d138daded63c0047e4c4f41955 > server/src/com/cloud/api/query/vo/UserVmJoinVO.java > f3f48fc9ae386362cb14fdb7c6605848553c88e0 > server/src/com/cloud/configuration/Config.java > 0ef0e252cbedfba9d120e1d309272058b25bb873 > server/src/com/cloud/configuration/ConfigurationManagerImpl.java > 57b50e672b3a93a1048ce17f10b2a4eb7b462eea > server/src/com/cloud/network/router/VirtualNetworkApplianceManager.java > 9fb47fde4f3711ba2a88ae047aa1ce159a390955 > server/src/com/cloud/network/vpc/VpcManagerImpl.java > fbb94c7ab0be7c2af86eeeb2a7fd61da27a91c5d > setup/db/db/schema-442to450.sql 843b8d0aeb6ea1960b4a0f56bd36d9591687a091 > setup/db/db/schema-450to460.sql 8480c850cef364f999fcfd3127a6af4d54344dbb > test/integration/component/maint/test_egress_rules_host_maintenance.py > a27ada3dcaef7af200abf7da97e93e1365c4abc4 > test/integration/component/test_bigswitch_bcf.py PRE-CREATION > test/integration/component/test_egress_rules.py > 0f05c07a2287fa0530a9cb750b0b32ef7f626918 > test/integration/component/test_security_groups.py > 89317f4373625f44f831699b66304865641b83b9 > tools/apidoc/gen_toc.py 95f06c8c1aa685c3b07967221e46daac0d34205c > tools/eclipse/eclipse.epf d7795aac4cf086f34169857b3048409a54932bb6 > ui/dictionary.jsp e1c19f36e581dc8a94e5c38038b3db4c5bfd8d3e > ui/dictionary2.jsp c61e841cb7697aa30fcb3375fb660fa462fbe990 > ui/scripts/configuration.js 0e673b3a4ab50cef37262f620fa49d7bfe31fde6 > ui/scripts/instances.js 7ee5db4e77ae7e39311fc0f60e846a375c31ec6d > ui/scripts/system.js b6a35a32e0529f0cb47145688c9e6e42a543a545 > ui/scripts/ui-custom/zoneWizard.js 02552f92c09078bd1c4e91bbd01b41755c3d6d33 > ui/scripts/ui/core.js 94edb194ab1b2948f4e3d5c07335dbed38d4943c > utils/src/com/cloud/utils/PasswordGenerator.java > b6e4bed080030b917a38edd461324da0e2080ed1 > utils/test/com/cloud/utils/PasswordGeneratorTest.java > 3e82d982857e998b5618097607cf6c2c8a91164b > > Diff: https://reviews.apache.org/r/24991/diff/ > > > Testing > ------- > > Passing unit tests > Added Marvin test (requires BCF controller) > Cleared Findbugs check > > > Thanks, > > Kuang-Ching Wang > >
