> On Feb. 5, 2015, 12:09 p.m., shweta agarwal wrote: > > test/integration/testpaths/testpath_usage.py, line 998 > > <https://reviews.apache.org/r/28030/diff/3/?file=845517#file845517line998> > > > > i dont think these two fileds templtat.id and record.usageid are same
It's as mentioned here - http://cloudstack-administration.readthedocs.org/en/latest/usage.html They are the same. > On Feb. 5, 2015, 12:09 p.m., shweta agarwal wrote: > > test/integration/testpaths/testpath_usage.py, line 1060 > > <https://reviews.apache.org/r/28030/diff/3/?file=845517#file845517line1060> > > > > change message to reflect usage for snamshot Yes, will update the comment. > On Feb. 5, 2015, 12:09 p.m., shweta agarwal wrote: > > test/integration/testpaths/testpath_usage.py, line 1251 > > <https://reviews.apache.org/r/28030/diff/3/?file=845517#file845517line1251> > > > > we can find acurate timing as well .so better check than just checking > > >0 Yes, will compare with exact value for usage. > On Feb. 5, 2015, 12:09 p.m., shweta agarwal wrote: > > test/integration/testpaths/testpath_usage.py, line 1031 > > <https://reviews.apache.org/r/28030/diff/3/?file=845517#file845517line1031> > > > > check only for equality Okay > On Feb. 5, 2015, 12:09 p.m., shweta agarwal wrote: > > test/integration/testpaths/testpath_usage.py, line 969 > > <https://reviews.apache.org/r/28030/diff/3/?file=845517#file845517line969> > > > > the check should only check for equality Okay > On Feb. 5, 2015, 12:09 p.m., shweta agarwal wrote: > > test/integration/testpaths/testpath_usage.py, line 935 > > <https://reviews.apache.org/r/28030/diff/3/?file=845517#file845517line935> > > > > i think just checking snapshot in description is a loose check we > > should check based on volume id Yes, agree will fix it. - Ashutosh ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/28030/#review71192 ----------------------------------------------------------- On Feb. 3, 2015, 12:24 p.m., Ashutosh Kelkar wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/28030/ > ----------------------------------------------------------- > > (Updated Feb. 3, 2015, 12:24 p.m.) > > > Review request for cloudstack and SrikanteswaraRao Talluri. > > > Bugs: CLOUDSTACK-7911 > https://issues.apache.org/jira/browse/CLOUDSTACK-7911 > > > Repository: cloudstack-git > > > Description > ------- > > Automation test cases for Usage test path. More test cases to follow. This is > first patch. > > > Diffs > ----- > > test/integration/testpaths/testpath_usage.py PRE-CREATION > tools/marvin/marvin/config/test_data.py d5ed353 > tools/marvin/marvin/dbConnection.py 66c6cb1 > tools/marvin/marvin/lib/base.py e38c394 > tools/marvin/marvin/lib/utils.py 8788b3b > > Diff: https://reviews.apache.org/r/28030/diff/ > > > Testing > ------- > > Yes. > > > Thanks, > > Ashutosh Kelkar > >
