> On Feb. 6, 2015, 9:13 a.m., shweta agarwal wrote: > > test/integration/testpaths/testpath_usage.py, line 2509 > > <https://reviews.apache.org/r/28030/diff/3/?file=845517#file845517line2509> > > > > not te right candidate for automation as we need to wt for 60 mins > > before usage records will be generated
Okay, Agree. We can skipp this test since we will have to wait for 60 mins before usage records will be generated. > On Feb. 6, 2015, 9:13 a.m., shweta agarwal wrote: > > test/integration/testpaths/testpath_usage.py, line 2401 > > <https://reviews.apache.org/r/28030/diff/3/?file=845517#file845517line2401> > > > > neeed to chane this as well no unknow in response Yes, the actual response value to compare is "cloudstack-usage: unrecognized service", I will fix it. > On Feb. 6, 2015, 9:13 a.m., shweta agarwal wrote: > > test/integration/testpaths/testpath_usage.py, line 2156 > > <https://reviews.apache.org/r/28030/diff/3/?file=845517#file845517line2156> > > > > not the right way to calculate network bytes send or receive in vpc > > networks. The calulation is done per public gateway for all the eth. Yes, agree. I will investiage on how to get this information from Router. > On Feb. 6, 2015, 9:13 a.m., shweta agarwal wrote: > > test/integration/testpaths/testpath_usage.py, line 2108 > > <https://reviews.apache.org/r/28030/diff/3/?file=845517#file845517line2108> > > > > its vpn user usage Yes, correct need to fix the Exception message saying "VPN user usage not matching" > On Feb. 6, 2015, 9:13 a.m., shweta agarwal wrote: > > test/integration/testpaths/testpath_usage.py, line 2099 > > <https://reviews.apache.org/r/28030/diff/3/?file=845517#file845517line2099> > > > > testing usage for vpn user Yes, correct need to fix the Exception message saying "VPN user usage not matching" > On Feb. 6, 2015, 9:13 a.m., shweta agarwal wrote: > > test/integration/testpaths/testpath_usage.py, line 1943 > > <https://reviews.apache.org/r/28030/diff/3/?file=845517#file845517line1943> > > > > not validating network usage for ip but for network offerings Yes, correct. > On Feb. 6, 2015, 9:13 a.m., shweta agarwal wrote: > > test/integration/testpaths/testpath_usage.py, line 1933 > > <https://reviews.apache.org/r/28030/diff/3/?file=845517#file845517line1933> > > > > similar usage ned to be checked for isolated network as well Yes, correct. I will add check for isolated network as well along with VPC network. > On Feb. 6, 2015, 9:13 a.m., shweta agarwal wrote: > > test/integration/testpaths/testpath_usage.py, line 1595 > > <https://reviews.apache.org/r/28030/diff/3/?file=845517#file845517line1595> > > > > need to check for acurate bytes > > only > than will not help Yes, agree. I will investiage on how to get this information from Router. - Ashutosh ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/28030/#review71381 ----------------------------------------------------------- On Feb. 3, 2015, 12:24 p.m., Ashutosh Kelkar wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/28030/ > ----------------------------------------------------------- > > (Updated Feb. 3, 2015, 12:24 p.m.) > > > Review request for cloudstack and SrikanteswaraRao Talluri. > > > Bugs: CLOUDSTACK-7911 > https://issues.apache.org/jira/browse/CLOUDSTACK-7911 > > > Repository: cloudstack-git > > > Description > ------- > > Automation test cases for Usage test path. More test cases to follow. This is > first patch. > > > Diffs > ----- > > test/integration/testpaths/testpath_usage.py PRE-CREATION > tools/marvin/marvin/config/test_data.py d5ed353 > tools/marvin/marvin/dbConnection.py 66c6cb1 > tools/marvin/marvin/lib/base.py e38c394 > tools/marvin/marvin/lib/utils.py 8788b3b > > Diff: https://reviews.apache.org/r/28030/diff/ > > > Testing > ------- > > Yes. > > > Thanks, > > Ashutosh Kelkar > >
