> On Jul 9, 2015, at 4:45 AM, Rajani Karuturi <raj...@apache.org> wrote: > > PR #565 is also closed with one review. > > I dont agree to adding an exception. Reviewing would be one way to get > others engaged and become aware. Otherwise, they lay there untouched and > unused. >
Let’s revert , that’s our new rule > I am sure we have enough committers who can review. Lately, lot more folks > are adding marvin tests as well. > > sailaja,sowmya,talluri,gaurav Can you review the PRs? > > Regarding the revert, > Maybe we can wait for 8 more hours (to catch up on IST and other timezones) > to get another review. If we dont get any review or if we get a -1, we > should revert. > > > ~Rajani > > On Thu, Jul 9, 2015 at 4:30 AM, David Nalley <da...@gnsa.us> wrote: > >> More tests are good, on the other hand exceptions tend to beget >> exceptions at tremendous speed. >> >> On Wed, Jul 8, 2015 at 7:48 AM, Daan Hoogland <daan.hoogl...@gmail.com> >> wrote: >>> That was never formalized, hence I put it as a shakespearian question. >>> I did sugest it otherwise I would have just reverted. I don't like the >>> exception but if the number of people working on integration is to low >>> to have a good flow we could. >>> >>> On Wed, Jul 8, 2015 at 1:46 PM, Sanjeev N <sanj...@apache.org> wrote: >>>> I thought there is a limitation on LGTMs for integration tests? >>>> >>>> On Wed, Jul 8, 2015 at 5:11 PM, Daan Hoogland <daan.hoogl...@gmail.com> >>>> wrote: >>>> >>>>> guys and dolss, >>>>> >>>>> this was closed with only 1 LGTM! we agreed not to submit with less >>>>> then two ok reviews on master. So next steps? revert? some extra >>>>> justification or else revert? ..... >>>>> >>>>> On Wed, Jul 8, 2015 at 12:39 PM, asfgit <g...@git.apache.org> wrote: >>>>>> Github user asfgit closed the pull request at: >>>>>> >>>>>> https://github.com/apache/cloudstack/pull/567 >>>>>> >>>>>> >>>>>> --- >>>>>> If your project is set up for it, you can reply to this email and >> have >>>>> your >>>>>> reply appear on GitHub as well. If your project does not have this >>>>> feature >>>>>> enabled and wishes so, or if the feature is enabled but not working, >>>>> please >>>>>> contact infrastructure at infrastruct...@apache.org or file a JIRA >>>>> ticket >>>>>> with INFRA. >>>>>> --- >>>>> >>>>> >>>>> >>>>> -- >>>>> Daan >>>>> >>> >>> >>> >>> -- >>> Daan >>
