We'll live with it this time I'd say ;-) Thanks for bringing it up! Regards, Remi
> On 06 Aug 2015, at 08:09, Mike Tutkowski <mike.tutkow...@solidfire.com> wrote: > > Fair enough > > Do you want me to revert this one or are we OK to just live with it? > > On Wed, Aug 5, 2015 at 11:57 PM, Remi Bergsma <rberg...@schubergphilis.com> > wrote: > >> Hi Mike, >> >> Yes, I want everything to go through a PR. >> >> Otherwise: >> - there are no Travis CI and other tests run >> - we need to describe what 'trivial' is and what not >> - the change is not visible >> >> The goal is a stable master at all times and we cannot reach that with >> direct commits. >> >> I do get your point, it feels like overhead and more work. You're not >> bothering! This workflow brings better quality when we all do this. It >> should be easy to get LGTMs fast on such a PR. Ping the list, as you did >> with the other PR and it will fly. >> >> Regards, Remi >> >>>> On 06 Aug 2015, at 06:48, Mike Tutkowski <mike.tutkow...@solidfire.com> >>> wrote: >>> >>> Hi everyone, >>> >>> Hopefully this isn't an issue, but I occasionally have super trivial, but >>> useful changes to SolidFire-only code that I'd like to push without >>> bothering with a PR. >>> >>> For example: >> https://git-wip-us.apache.org/repos/asf?p=cloudstack.git;a=blob;f=plugins/storage/volume/solidfire/src/org/apache/cloudstack/storage/datastore/lifecycle/SolidFireSharedPrimaryDataStoreLifeCycle.java;h=7cb690014bbc4834c430febe050ccb133528e1fb;hb=2c8d179b7abf6da1c99390788c3329f243e172db >>> >>> In this commit, I renamed two variables to be more descriptive. It only >>> impacts the SolidFire plug-in and is purely for readability. >>> >>> Does this sound OK to do or do we literally want ever single change (no >>> matter how trivial) to go in via PR? >>> >>> Thanks! >>> >>> -- >>> *Mike Tutkowski* >>> *Senior CloudStack Developer, SolidFire Inc.* >>> e: mike.tutkow...@solidfire.com >>> o: 303.746.7302 >>> Advancing the way the world uses the cloud >>> <http://solidfire.com/solution/overview/?video=play>*™* > > > > -- > *Mike Tutkowski* > *Senior CloudStack Developer, SolidFire Inc.* > e: mike.tutkow...@solidfire.com > o: 303.746.7302 > Advancing the way the world uses the cloud > <http://solidfire.com/solution/overview/?video=play>*™*
