Github user koushik-das commented on a diff in the pull request:

    https://github.com/apache/cloudstack/pull/666#discussion_r36527589
  
    --- Diff: 
server/src/com/cloud/network/router/VirtualNetworkApplianceManagerImpl.java ---
    @@ -2627,7 +2627,7 @@ public boolean postStateTransitionEvent(final 
StateMachine2.Transition<State, Vi
                     s_logger.info("Schedule a router reboot task as router " + 
vo.getId() + " is powered-on out-of-band. we need to reboot to refresh network 
rules");
    --- End diff --
    
    @DaanHoogland I see that you introduced 
RouterReprovisionOnOutOfBandMigration as part of commit 
b9dd67c383874ef7273205e0eac831de497bb02d. Wasn't this config just meant to 
decide between VR reboot and generating alert? But I see that both 'if' and 
'else' conditions are different. Has something changed?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

Reply via email to