Github user DaanHoogland commented on the pull request:
https://github.com/apache/cloudstack/pull/689#issuecomment-133335452
I saw @jburwell his remarks coming by. I trust him to be thorough. I will
review when I see unit and integration tests.
try using more try with resource when possible. No beef just
try (Transaction trx =TransactionLegacy.open(TransactionLegacy.USAGE_DB))
{} is an often used pattern. maybe create a method/utility called switchDb(...)
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
